Refactor copy to use opendir
#1028
Merged
+30
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanZim
reviewed
Nov 28, 2023
RyanZim
approved these changes
Dec 1, 2023
Contributor
Author
Collaborator
|
@SukkaW sorry for long delay! I appreciate the work! |
jelmore1674
added a commit
to jelmore1674/build-changelog
that referenced
this pull request
Mar 19, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [fs-extra](https://github.com/jprichardson/node-fs-extra) | devDependencies | minor | [`11.2.0` -> `11.3.0`](https://renovatebot.com/diffs/npm/fs-extra/11.2.0/11.3.0) | --- ### Release Notes <details> <summary>jprichardson/node-fs-extra (fs-extra)</summary> ### [`v11.3.0`](https://github.com/jprichardson/node-fs-extra/blob/HEAD/CHANGELOG.md#1130--2025-01-15) [Compare Source](jprichardson/node-fs-extra@11.2.0...11.3.0) - Add promise support for newer `fs` methods ([#​1044](jprichardson/node-fs-extra#1044), [#​1045](jprichardson/node-fs-extra#1045)) - Use `fs.opendir` in `copy()`/`copySync()` for better perf/scalability ([#​972](jprichardson/node-fs-extra#972), [#​1028](jprichardson/node-fs-extra#1028)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMDcuMiIsInVwZGF0ZWRJblZlciI6IjM5LjEwNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://git.justinelmore.dev/jelmore1674/build-changelog/pulls/78 Co-authored-by: Renovate Bot <renovate-bot@forgejo.justinelmore.dev> Co-committed-by: Renovate Bot <renovate-bot@forgejo.justinelmore.dev> chore: update changelog
valentineus
pushed a commit
to valentineus/strapi-plugin-checkbox-list
that referenced
this pull request
Feb 5, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [fs-extra](https://github.com/jprichardson/node-fs-extra) | [`^10.0.0` → `^11.0.0`](https://renovatebot.com/diffs/npm/fs-extra/10.1.0/11.3.3) |  |  | --- ### Release Notes <details> <summary>jprichardson/node-fs-extra (fs-extra)</summary> ### [`v11.3.3`](https://github.com/jprichardson/node-fs-extra/blob/HEAD/CHANGELOG.md#1133--2025-12-18) [Compare Source](jprichardson/node-fs-extra@11.3.2...11.3.3) - Fix copying symlink when destination is a symlink to the same target ([#​1019](jprichardson/node-fs-extra#1019), [#​1060](jprichardson/node-fs-extra#1060)) ### [`v11.3.2`](https://github.com/jprichardson/node-fs-extra/blob/HEAD/CHANGELOG.md#1132--2025-09-15) [Compare Source](jprichardson/node-fs-extra@11.3.1...11.3.2) - Fix spurrious `UnhandledPromiseRejectionWarning` that could occur when calling `.copy()` in some cases ([#​1056](jprichardson/node-fs-extra#1056), [#​1058](jprichardson/node-fs-extra#1058)) ### [`v11.3.1`](https://github.com/jprichardson/node-fs-extra/blob/HEAD/CHANGELOG.md#1131--2025-08-05) [Compare Source](jprichardson/node-fs-extra@11.3.0...11.3.1) - Fix case where `move`/`moveSync` could incorrectly think files are identical on Windows ([#​1050](jprichardson/node-fs-extra#1050)) ### [`v11.3.0`](https://github.com/jprichardson/node-fs-extra/blob/HEAD/CHANGELOG.md#1130--2025-01-15) [Compare Source](jprichardson/node-fs-extra@11.2.0...11.3.0) - Add promise support for newer `fs` methods ([#​1044](jprichardson/node-fs-extra#1044), [#​1045](jprichardson/node-fs-extra#1045)) - Use `fs.opendir` in `copy()`/`copySync()` for better perf/scalability ([#​972](jprichardson/node-fs-extra#972), [#​1028](jprichardson/node-fs-extra#1028)) ### [`v11.2.0`](https://github.com/jprichardson/node-fs-extra/blob/HEAD/CHANGELOG.md#1120--2023-11-27) [Compare Source](jprichardson/node-fs-extra@11.1.1...11.2.0) - Copy directory contents in parallel for better performance ([#​1026](jprichardson/node-fs-extra#1026)) - Refactor internal code to use `async`/`await` ([#​1020](jprichardson/node-fs-extra#1020)) ### [`v11.1.1`](https://github.com/jprichardson/node-fs-extra/blob/HEAD/CHANGELOG.md#1111--2023-03-20) [Compare Source](jprichardson/node-fs-extra@11.1.0...11.1.1) - Preserve timestamps when moving files across devices ([#​992](jprichardson/node-fs-extra#992), [#​994](jprichardson/node-fs-extra#994)) ### [`v11.1.0`](https://github.com/jprichardson/node-fs-extra/blob/HEAD/CHANGELOG.md#1110--2022-11-29) [Compare Source](jprichardson/node-fs-extra@11.0.0...11.1.0) - Re-add `main` field to `package.json` for better TypeScript compatibility ([#​979](jprichardson/node-fs-extra#979), [#​981](jprichardson/node-fs-extra#981)) ### [`v11.0.0`](https://github.com/jprichardson/node-fs-extra/blob/HEAD/CHANGELOG.md#1100--2022-11-28) [Compare Source](jprichardson/node-fs-extra@10.1.0...11.0.0) ##### Breaking Changes - Don't allow requiring `fs-extra/lib/SOMETHING` (switched to `exports`) ([#​974](jprichardson/node-fs-extra#974)) - Require Node v14.14+ ([#​968](jprichardson/node-fs-extra#968), [#​969](jprichardson/node-fs-extra#969)) ##### New Features - Add `fs-extra/esm` for ESM named export support; see [docs](https://github.com/jprichardson/node-fs-extra#esm) for details ([#​746](jprichardson/node-fs-extra#746), [#​974](jprichardson/node-fs-extra#974)) - Add promise support for `fs.readv()` ([#​970](jprichardson/node-fs-extra#970)) ##### Bugfixes - Don't `stat` filtered items in `copy*` ([#​965](jprichardson/node-fs-extra#965), [#​971](jprichardson/node-fs-extra#971)) - Remove buggy stats check in `copy` ([#​918](jprichardson/node-fs-extra#918), [#​976](jprichardson/node-fs-extra#976)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4wLjUiLCJ1cGRhdGVkSW5WZXIiOiI0My4wLjUiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIiLCJsYWJlbHMiOlsiYXV0b21hdGVkIiwiZGVwZW5kZW5jaWVzIl19--> Reviewed-on: https://code.popov.link/valentineus/strapi-plugin-checkbox-list/pulls/6 Co-authored-by: renovate[bot] <renovatebot@noreply.localhost> Co-committed-by: renovate[bot] <renovatebot@noreply.localhost>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR closes #972.
The
readdirreturns the contents of a directory all at once, which can be slow (and blocking) when a directory contains many items. Theopendirreturns the contents of a directory one at a time.Unlike the original Node.js changes (which copy items one by one), this PR retains copy in parallel (as introduced in #1026).