refactor: do not use "remote" module for console calls #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykuzmin
force-pushed
the
use-fake-console-for-renderer
branch
from
71ccc85 to
c879f21
Compare
alexeykuzmin
force-pushed
the
use-fake-console-for-renderer
branch
from
c879f21 to
9a98f20
Compare
Collaborator
|
Thanks! We previously only forwarded the log and dir, so I'll add an option to opt-in or out of printing warnings. |
inukshuk
added a commit
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron allows disabling "remote" module at build time.
Let's make "electron-mocha" work for such builds.
Avoid using "remote" module and use IPC calls
for console logging in non-interactive renderers.
Based on what Electron itself does for its tests
https://github.com/electron/electron/blob/22cb3cd18b1b771364edada515a4c138a8dddc6d/spec/static/main.js#L55-L63
https://github.com/electron/electron/blob/22cb3cd18b1b771364edada515a4c138a8dddc6d/spec/static/index.html#L18-L27