Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esbuild error on node 12 #854

Closed
heswell opened this issue Oct 2, 2021 · 1 comment · Fixed by #843
Closed

esbuild error on node 12 #854

heswell opened this issue Oct 2, 2021 · 1 comment · Fixed by #843
Labels
bug Something isn't working

Comments

@heswell
Copy link

heswell commented Oct 2, 2021

supported engines include node "^12.13.0". However esbuild support for all v12 versions of node is broken by the following

import * as fs from “fs/promises”

There are several occurrences of this across modular scripts, one example:
https://github.com/jpmorganchase/modular/blob/main/packages/modular-scripts/src/esbuild-scripts/api.ts#L1

it is easily fixed
nodejs/node#35740 (comment)
@heswell heswell added the bug Something isn't working label Oct 2, 2021
@LukeSheard
Copy link
Contributor

There's already an open PR for this in #843 which is being merged today.

@LukeSheard LukeSheard mentioned this issue Oct 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove references to fs/promises jpmorganchase/modular
2 participants
@heswell @LukeSheard