Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent terminology in Report Viewer #1278

Closed
4 tasks done
Kr0nox opened this issue Sep 3, 2023 · 0 comments · Fixed by #1339
Closed
4 tasks done

Inconsistent terminology in Report Viewer #1278

Kr0nox opened this issue Sep 3, 2023 · 0 comments · Fixed by #1339
Assignees
@Kr0nox
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Milestone
v5.0.0

Comments

@Kr0nox
Copy link
Member

Kr0nox commented Sep 3, 2023 •
edited
Loading

Even though it has gotten a bit better with the redesign (#1145) there is still not a lot of non matching terminology across views and sometimes even in the same view.
We would need to discuss which terms we want across the viewer.
Feel free to add to this list:

  • Directory vs Submission Folder (Overview and InfoView) => Submission Directory
  • Total Submissions vs Submission Count (Overview and InfoView) => Total Submissions
  • Min Match Length vs Minimum Token Match (Overview and InfoView) => Min Token Match
  • Average vs Average Similarity (Selectors on Overview) (same for Maximum)
@Kr0nox Kr0nox self-assigned this Sep 4, 2023
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Sep 28, 2023
@tsaglam tsaglam added this to the v5.0.0 milestone Sep 28, 2023
@Kr0nox Kr0nox linked a pull request Nov 1, 2023 that will close this issue
improve information on overview #1339
Merged
@Kr0nox Kr0nox closed this as completed Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kr0nox Kr0nox

Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging a pull request may close this issue.

improve information on overview jplag/JPlag
2 participants
@tsaglam @Kr0nox