-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Automatically reload auth file #30
Labels
Comments
I think a poll every 5 seconds would be simplest. It's not a huge change, would you willing to send a PR? These lines from users, err := chshare.ParseUsers(config.AuthFile)
if err != nil {
return nil, err
}
s.Users = users The function can run in a loop on a timer, it will need to be guarded with file change detection, and |
jpillora
changed the title
Live reloading of auth file
[Feature] Automatically reload auth file
Apr 14, 2017
jpillora
changed the title
[Feature] Automatically reload auth file
[Feature Request] Automatically reload auth file
Apr 14, 2017
Yea mate, I'll take a stab at it. Cheers |
Merged
Option 3. has been implemented in 1.2.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This feature assumes connections will be broken if server is restarted.
This would come in handy for building the auth file programmatically from a separate data source to avoid.
There's three ways we could do it in increasing levels of complexity:
Not sure which will be best.
The text was updated successfully, but these errors were encountered: