Skip to content

Commit e01d421

Browse files
authored
Merge pull request nasa#880 from skliper/fix796-reduce-ver-depend
Fix nasa#796, Remove dependency on CCSDS version define
2 parents 983157d + b70a1a3 commit e01d421

File tree

12 files changed

+91
-269
lines changed

12 files changed

+91
-269
lines changed

cmake/sample_defs/cpu1_msgids.h

Lines changed: 70 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -41,53 +41,94 @@
4141

4242
#include "cfe_mission_cfg.h"
4343

44+
/**
45+
* \brief Platform command message ID base offset
46+
*
47+
* Example mechanism for setting default command bits and deconflicting MIDs across multiple
48+
* platforms in a mission. For any sufficiently complex mission this method is
49+
* typically replaced by a centralized message ID management scheme.
50+
*
51+
* 0x1800 - Nominal value for default message ID implementation (V1). This sets the command
52+
* field and the secondary header present field. Typical V1 command MID range
53+
* is 0x1800-1FFF. Additional cpus can deconflict message IDs by incrementing
54+
* this value to provide sub-allocations (0x1900 for example).
55+
* 0x0080 - Command bit for MISSION_MSGID_V2 message ID implementation (V2). Although
56+
* this can be used for the value below due to the relatively small set
57+
* of MIDs in the framework it will not scale so an alternative
58+
* method of deconfliction is recommended.
59+
*/
60+
#define CFE_PLATFORM_CMD_MID_BASE 0x1800
61+
62+
/**
63+
* \brief Platform telemetry message ID base offset
64+
*
65+
* 0x0800 - Nominal for message ID V1
66+
* 0x0000 - Potential value for MISSION_MSGID_V2, but limited to a range of
67+
* 0x0000-0x007F since the command bit is 0x0080. Alternative
68+
* method of deconfliction is recommended.
69+
*
70+
* See #CFE_PLATFORM_CMD_MID_BASE for more information
71+
*/
72+
#define CFE_PLATFORM_TLM_MID_BASE 0x0800
73+
74+
/**
75+
* \brief "Global" command message ID base offset
76+
*
77+
* 0x1860 - Nominal value for message ID V1
78+
* 0x00E0 - Potential value for MISSION_MSGID_V2, note command bit is 0x0080.
79+
* Works in limited cases only, alternative method of deconfliction
80+
* is recommended.
81+
* See #CFE_PLATFORM_CMD_MID_BASE for more information
82+
*/
83+
#define CFE_PLATFORM_CMD_MID_BASE_GLOB 0x1860
84+
4485
/*
4586
** cFE Command Message Id's
4687
*/
47-
#define CFE_EVS_CMD_MID CFE_MISSION_CMD_MID_BASE1 + CFE_MISSION_EVS_CMD_MSG /* 0x1801 */
88+
#define CFE_EVS_CMD_MID CFE_PLATFORM_CMD_MID_BASE + CFE_MISSION_EVS_CMD_MSG /* 0x1801 */
4889
/* Message ID 0x1802 is available */
49-
#define CFE_SB_CMD_MID CFE_MISSION_CMD_MID_BASE1 + CFE_MISSION_SB_CMD_MSG /* 0x1803 */
50-
#define CFE_TBL_CMD_MID CFE_MISSION_CMD_MID_BASE1 + CFE_MISSION_TBL_CMD_MSG /* 0x1804 */
51-
#define CFE_TIME_CMD_MID CFE_MISSION_CMD_MID_BASE1 + CFE_MISSION_TIME_CMD_MSG /* 0x1805 */
52-
#define CFE_ES_CMD_MID CFE_MISSION_CMD_MID_BASE1 + CFE_MISSION_ES_CMD_MSG /* 0x1806 */
90+
#define CFE_SB_CMD_MID CFE_PLATFORM_CMD_MID_BASE + CFE_MISSION_SB_CMD_MSG /* 0x1803 */
91+
#define CFE_TBL_CMD_MID CFE_PLATFORM_CMD_MID_BASE + CFE_MISSION_TBL_CMD_MSG /* 0x1804 */
92+
#define CFE_TIME_CMD_MID CFE_PLATFORM_CMD_MID_BASE + CFE_MISSION_TIME_CMD_MSG /* 0x1805 */
93+
#define CFE_ES_CMD_MID CFE_PLATFORM_CMD_MID_BASE + CFE_MISSION_ES_CMD_MSG /* 0x1806 */
5394

54-
#define CFE_ES_SEND_HK_MID CFE_MISSION_CMD_MID_BASE1 + CFE_MISSION_ES_SEND_HK_MSG /* 0x1808 */
55-
#define CFE_EVS_SEND_HK_MID CFE_MISSION_CMD_MID_BASE1 + CFE_MISSION_EVS_SEND_HK_MSG /* 0x1809 */
95+
#define CFE_ES_SEND_HK_MID CFE_PLATFORM_CMD_MID_BASE + CFE_MISSION_ES_SEND_HK_MSG /* 0x1808 */
96+
#define CFE_EVS_SEND_HK_MID CFE_PLATFORM_CMD_MID_BASE + CFE_MISSION_EVS_SEND_HK_MSG /* 0x1809 */
5697
/* Message ID 0x180A is available */
57-
#define CFE_SB_SEND_HK_MID CFE_MISSION_CMD_MID_BASE1 + CFE_MISSION_SB_SEND_HK_MSG /* 0x180B */
58-
#define CFE_TBL_SEND_HK_MID CFE_MISSION_CMD_MID_BASE1 + CFE_MISSION_TBL_SEND_HK_MSG /* 0x180C */
59-
#define CFE_TIME_SEND_HK_MID CFE_MISSION_CMD_MID_BASE1 + CFE_MISSION_TIME_SEND_HK_MSG /* 0x180D */
98+
#define CFE_SB_SEND_HK_MID CFE_PLATFORM_CMD_MID_BASE + CFE_MISSION_SB_SEND_HK_MSG /* 0x180B */
99+
#define CFE_TBL_SEND_HK_MID CFE_PLATFORM_CMD_MID_BASE + CFE_MISSION_TBL_SEND_HK_MSG /* 0x180C */
100+
#define CFE_TIME_SEND_HK_MID CFE_PLATFORM_CMD_MID_BASE + CFE_MISSION_TIME_SEND_HK_MSG /* 0x180D */
60101

61-
#define CFE_SB_SUB_RPT_CTRL_MID CFE_MISSION_CMD_MID_BASE1 + CFE_MISSION_SB_SUB_RPT_CTRL_MSG /* 0x180E */
102+
#define CFE_SB_SUB_RPT_CTRL_MID CFE_PLATFORM_CMD_MID_BASE + CFE_MISSION_SB_SUB_RPT_CTRL_MSG /* 0x180E */
62103

63-
#define CFE_TIME_TONE_CMD_MID CFE_MISSION_CMD_MID_BASE1 + CFE_MISSION_TIME_TONE_CMD_MSG /* 0x1810 */
64-
#define CFE_TIME_1HZ_CMD_MID CFE_MISSION_CMD_MID_BASE1 + CFE_MISSION_TIME_1HZ_CMD_MSG /* 0x1811 */
104+
#define CFE_TIME_TONE_CMD_MID CFE_PLATFORM_CMD_MID_BASE + CFE_MISSION_TIME_TONE_CMD_MSG /* 0x1810 */
105+
#define CFE_TIME_1HZ_CMD_MID CFE_PLATFORM_CMD_MID_BASE + CFE_MISSION_TIME_1HZ_CMD_MSG /* 0x1811 */
65106

66107

67108
/*
68109
** cFE Global Command Message Id's
69110
*/
70-
#define CFE_TIME_DATA_CMD_MID CFE_MISSION_CMD_MID_BASE_GLOB + CFE_MISSION_TIME_DATA_CMD_MSG /* 0x1860 */
71-
#define CFE_TIME_SEND_CMD_MID CFE_MISSION_CMD_MID_BASE_GLOB + CFE_MISSION_TIME_SEND_CMD_MSG /* 0x1862 */
111+
#define CFE_TIME_DATA_CMD_MID CFE_PLATFORM_CMD_MID_BASE_GLOB + CFE_MISSION_TIME_DATA_CMD_MSG /* 0x1860 */
112+
#define CFE_TIME_SEND_CMD_MID CFE_PLATFORM_CMD_MID_BASE_GLOB + CFE_MISSION_TIME_SEND_CMD_MSG /* 0x1862 */
72113

73114

74115
/*
75116
** CFE Telemetry Message Id's
76117
*/
77-
#define CFE_ES_HK_TLM_MID CFE_MISSION_TLM_MID_BASE1 + CFE_MISSION_ES_HK_TLM_MSG /* 0x0800 */
78-
#define CFE_EVS_HK_TLM_MID CFE_MISSION_TLM_MID_BASE1 + CFE_MISSION_EVS_HK_TLM_MSG /* 0x0801 */
118+
#define CFE_ES_HK_TLM_MID CFE_PLATFORM_TLM_MID_BASE + CFE_MISSION_ES_HK_TLM_MSG /* 0x0800 */
119+
#define CFE_EVS_HK_TLM_MID CFE_PLATFORM_TLM_MID_BASE + CFE_MISSION_EVS_HK_TLM_MSG /* 0x0801 */
79120
/* Message ID 0x0802 is available */
80-
#define CFE_SB_HK_TLM_MID CFE_MISSION_TLM_MID_BASE1 + CFE_MISSION_SB_HK_TLM_MSG /* 0x0803 */
81-
#define CFE_TBL_HK_TLM_MID CFE_MISSION_TLM_MID_BASE1 + CFE_MISSION_TBL_HK_TLM_MSG /* 0x0804 */
82-
#define CFE_TIME_HK_TLM_MID CFE_MISSION_TLM_MID_BASE1 + CFE_MISSION_TIME_HK_TLM_MSG /* 0x0805 */
83-
#define CFE_TIME_DIAG_TLM_MID CFE_MISSION_TLM_MID_BASE1 + CFE_MISSION_TIME_DIAG_TLM_MSG /* 0x0806 */
84-
#define CFE_EVS_LONG_EVENT_MSG_MID CFE_MISSION_TLM_MID_BASE1 + CFE_MISSION_EVS_LONG_EVENT_MSG_MSG /* 0x0808 */
85-
#define CFE_EVS_SHORT_EVENT_MSG_MID CFE_MISSION_TLM_MID_BASE1 + CFE_MISSION_EVS_SHORT_EVENT_MSG_MSG /* 0x0809 */
86-
#define CFE_SB_STATS_TLM_MID CFE_MISSION_TLM_MID_BASE1 + CFE_MISSION_SB_STATS_TLM_MSG /* 0x080A */
87-
#define CFE_ES_APP_TLM_MID CFE_MISSION_TLM_MID_BASE1 + CFE_MISSION_ES_APP_TLM_MSG /* 0x080B */
88-
#define CFE_TBL_REG_TLM_MID CFE_MISSION_TLM_MID_BASE1 + CFE_MISSION_TBL_REG_TLM_MSG /* 0x080C */
89-
#define CFE_SB_ALLSUBS_TLM_MID CFE_MISSION_TLM_MID_BASE1 + CFE_MISSION_SB_ALLSUBS_TLM_MSG /* 0x080D */
90-
#define CFE_SB_ONESUB_TLM_MID CFE_MISSION_TLM_MID_BASE1 + CFE_MISSION_SB_ONESUB_TLM_MSG /* 0x080E */
91-
#define CFE_ES_MEMSTATS_TLM_MID CFE_MISSION_TLM_MID_BASE1 + CFE_MISSION_ES_MEMSTATS_TLM_MSG /* 0x0810 */
121+
#define CFE_SB_HK_TLM_MID CFE_PLATFORM_TLM_MID_BASE + CFE_MISSION_SB_HK_TLM_MSG /* 0x0803 */
122+
#define CFE_TBL_HK_TLM_MID CFE_PLATFORM_TLM_MID_BASE + CFE_MISSION_TBL_HK_TLM_MSG /* 0x0804 */
123+
#define CFE_TIME_HK_TLM_MID CFE_PLATFORM_TLM_MID_BASE + CFE_MISSION_TIME_HK_TLM_MSG /* 0x0805 */
124+
#define CFE_TIME_DIAG_TLM_MID CFE_PLATFORM_TLM_MID_BASE + CFE_MISSION_TIME_DIAG_TLM_MSG /* 0x0806 */
125+
#define CFE_EVS_LONG_EVENT_MSG_MID CFE_PLATFORM_TLM_MID_BASE + CFE_MISSION_EVS_LONG_EVENT_MSG_MSG /* 0x0808 */
126+
#define CFE_EVS_SHORT_EVENT_MSG_MID CFE_PLATFORM_TLM_MID_BASE + CFE_MISSION_EVS_SHORT_EVENT_MSG_MSG /* 0x0809 */
127+
#define CFE_SB_STATS_TLM_MID CFE_PLATFORM_TLM_MID_BASE + CFE_MISSION_SB_STATS_TLM_MSG /* 0x080A */
128+
#define CFE_ES_APP_TLM_MID CFE_PLATFORM_TLM_MID_BASE + CFE_MISSION_ES_APP_TLM_MSG /* 0x080B */
129+
#define CFE_TBL_REG_TLM_MID CFE_PLATFORM_TLM_MID_BASE + CFE_MISSION_TBL_REG_TLM_MSG /* 0x080C */
130+
#define CFE_SB_ALLSUBS_TLM_MID CFE_PLATFORM_TLM_MID_BASE + CFE_MISSION_SB_ALLSUBS_TLM_MSG /* 0x080D */
131+
#define CFE_SB_ONESUB_TLM_MID CFE_PLATFORM_TLM_MID_BASE + CFE_MISSION_SB_ONESUB_TLM_MSG /* 0x080E */
132+
#define CFE_ES_MEMSTATS_TLM_MID CFE_PLATFORM_TLM_MID_BASE + CFE_MISSION_ES_MEMSTATS_TLM_MSG /* 0x0810 */
92133

93134
#endif

cmake/sample_defs/sample_mission_cfg.h

Lines changed: 0 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -52,21 +52,6 @@
5252
#define CFE_MISSION_SPACECRAFT_ID 0x42
5353

5454

55-
/**
56-
** \cfemissioncfg cFE SB message format
57-
**
58-
** \par Description:
59-
** Dictates the message format used by the cFE.
60-
**
61-
** \par Limits
62-
** All versions of the cFE currently support only CCSDS as the message format
63-
** Defining MESSAGE_FORMAT_IS_CCSDS_VER_2 implements the APID extended header format
64-
** MESSAGE_FORMAT_IS_CCSDS_VER_2 is optional
65-
*/
66-
/* #define MESSAGE_FORMAT_IS_CCSDS_VER_2 */
67-
#undef MESSAGE_FORMAT_IS_CCSDS_VER_2
68-
69-
7055
/**
7156
** \cfesbcfg Maximum SB Message Size
7257
**
@@ -335,48 +320,6 @@
335320
#define CFE_MISSION_TBL_MAX_NAME_LENGTH 16
336321

337322

338-
/**
339-
** \cfemissioncfg cFE Message ID Base Numbers
340-
**
341-
** \par Description:
342-
** Message Id base numbers for the cFE messages
343-
** These will now differ in format when using CCSDS version 2 as they will no longer
344-
** include the Secondary Header Flag and CCSDS version bits.
345-
**
346-
** NOTES: cFE MsgIds are the sum of the base numbers and the portable msg
347-
** numbers.
348-
**
349-
** For MESSAGE_FORMAT_IS_CCSDS_VER_2 These base MsgIds values are dependent on the
350-
** values returned by the following SB Macros to form a 16 bit message ID (default
351-
** macro definitions are in cfe_sb_msg_id_utils.h, default values below are
352-
** representative of default macro definitions) :
353-
** CFE_SB_CMD_MESSAGE_TYPE, CFE_SB_RD_APID_FROM_MSGID
354-
** CFE_SB_RD_SUBSYS_ID_FROM_MSGID and CFE_SB_RD_TYPE_FROM_MSGID
355-
**
356-
** \par Limits
357-
** Must be less than CFE_PLATFORM_SB_HIGHEST_VALID_MSGID
358-
*/
359-
#ifndef MESSAGE_FORMAT_IS_CCSDS_VER_2
360-
#define CFE_MISSION_CMD_MID_BASE1 0x1800
361-
#define CFE_MISSION_TLM_MID_BASE1 0x0800
362-
#else
363-
#define CFE_MISSION_CMD_MID_BASE1 0x0080
364-
#define CFE_MISSION_TLM_MID_BASE1 0x0000
365-
#endif
366-
367-
#define CFE_MISSION_CMD_APPID_BASE1 1
368-
#define CFE_MISSION_TLM_APPID_BASE1 0
369-
370-
#ifndef MESSAGE_FORMAT_IS_CCSDS_VER_2
371-
#define CFE_MISSION_CMD_MID_BASE_GLOB 0x1860
372-
#define CFE_MISSION_TLM_MID_BASE_GLOB 0x0860
373-
#else
374-
#define CFE_MISSION_CMD_MID_BASE_GLOB 0x00E0
375-
#define CFE_MISSION_TLM_MID_BASE_GLOB 0x0060
376-
#endif
377-
378-
379-
380323
/**
381324
** \cfemissioncfg cFE Portable Message Numbers for Commands
382325
**

docs/src/cfe_sb.dox

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -60,32 +60,29 @@
6060
All commands, telemetry, and other data that are passed between the ground and
6161
the spacecraft, and between subsystems of the spacecraft, are considered to be
6262
messages. The most common message format is CCSDS (Consultative Committee for
63-
Space Data Systems).
64-
65-
The cFE software bus was designed with 'hooks' to allow message formats other
66-
than CCSDS to be used. The APIs that are used to set and get message header
67-
fields are intentionally designed to be decoupled from CCSDS.
63+
Space Data Systems) in <a href="https://public.ccsds.org/Pubs/133x0b2.pdf">
64+
CCSDS Space Packet Protocol</a>, but can be customized by replacing the message module.
6865

6966
There are two general types of messages - commands (or command packets) and
7067
telemetry (or telemetry packets). Command packets are sent to a particular
7168
software task from the ground (or another task). Telemetry packets are sent
7269
from a particular software task to the ground (or other tasks).
7370

74-
Each packet begins with a header that includes the message identifier, often
75-
abbreviated as MsgId or message ID. The MsgId for CCSDS messages is the first
76-
16 bits of the packet. The message 'type' indicator (command or telemetry) is
77-
embedded in the Message ID. The header also contains a packet length field and a
78-
packet sequence field. The packet sequence field is incremented by the software
79-
bus for telemetry packets each time a packet is sent. The software bus does not
80-
increment the sequence field for command packets. See the section named 'Packet
81-
Sequence Values' for more detail.
82-
71+
The concept of a message identifier is utilized to provide abstraction
72+
from header implementation, often abbreviated as message ID, MsgId, or MID.
73+
Header and message identifier values should not be accessed directly to
74+
avoid implementation specific dependencies.
75+
8376
Telemetry packets typically contain a timestamp that indicates when the packet
8477
was produced. Command packets typically contain a command code that identifies
8578
the particular type of command.
8679

87-
The software bus provides APIs for 'setting' and 'getting' the fields in the
88-
header of the message.
80+
The message module provides APIs for 'setting' and 'getting' the fields in the
81+
header of the message. The message module was separated from software bus
82+
to enable users to customize message headers without requiring clone and
83+
own of the entire cfe repository. To customize, remove the built in msg
84+
module from the build and replace with custom implementation. See sample
85+
target definitions folder for examples.
8986

9087
Following the header is the user defined message data.
9188

fsw/cfe-core/src/inc/cfe_sb_extern_typedefs.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,12 +94,9 @@ typedef uint16 CFE_SB_MsgRouteIdx_Atom_t;
9494
* @brief CFE_SB_MsgId_Atom_t primitive type definition
9595
*
9696
* This is an integer type capable of holding any Message ID value
97+
* Note: This value is limited via #CFE_PLATFORM_SB_HIGHEST_VALID_MSGID
9798
*/
98-
#ifdef MESSAGE_FORMAT_IS_CCSDS_VER_2
9999
typedef uint32 CFE_SB_MsgId_Atom_t;
100-
#else
101-
typedef uint16 CFE_SB_MsgId_Atom_t;
102-
#endif
103100

104101
/**
105102
* @brief CFE_SB_MsgId_t type definition

fsw/cfe-core/src/sb/cfe_sb_init.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -223,12 +223,6 @@ void CFE_SB_InitMsgMap(void){
223223
CFE_SB.MsgMap[KeyVal] = CFE_SB_INVALID_ROUTE_IDX;
224224
}
225225

226-
#ifndef MESSAGE_FORMAT_IS_CCSDS_VER_2 /* Then use the default, version 1 */
227-
CFE_ES_WriteToSysLog("SB internal message format: CCSDS Space Packet Protocol version 1\n");
228-
#else /* VER_2 is the same now but will change for larger and/or distributed systems */
229-
CFE_ES_WriteToSysLog("SB internal message format: Space Packet Protocol version 2 (extended hdr)\n");
230-
#endif
231-
232226
}/* end CFE_SB_InitMsgMap */
233227

234228

fsw/cfe-core/src/sb/cfe_sb_msg_id_util.c

Lines changed: 2 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -20,66 +20,8 @@
2020

2121
/******************************************************************************
2222
** File: cfe_sb_msg_id_util.c
23-
**
24-
** Purpose:
25-
** This file contains 'access' macros and functions for reading and
26-
** writing message ID header fields.
27-
**
28-
** The function prototypes are in cfe_sb.h except for ConvertMsgIdToMsgKey
29-
** which is in cfe_sb_priv.h
30-
*
31-
** The MsgId is a mission defined message identifier to publish or subscribe to that must be
32-
** unique within the system(s). CFE_SB_MsgId_t is a uint32 that can be created from any
33-
** combination of bits from the primary header SID (StreamId) and the secondary header APID Qualifiers
34-
**
35-
** Implementation is based on CCSDS Space Packet Protocol 133.0.B-1 with Technical Corrigendum 2, September 2012
36-
** Multi-mission Interoperable extended secondary headers should be registered in Space
37-
** Assigned Numbers Authority (SANA). The process for SANA registration is documented in
38-
** 133.0.B-2. Mission specific headers need not be registered
39-
**
40-
** For MESSAGE_FORMAT_IS_CCSDS_VER_2 the default setup will combine:
41-
** 1 bit for the command/telemetry flag
42-
** 7 bits from the primary header APID
43-
** 0 bits from the Playback flag
44-
** 8 bits from the secondary header APID qualifier (Subsystem)
45-
** 0 bits from the secondary header APID qualifier as the System
46-
** = 16 bits total
47-
**
48-
**
49-
** The APID qualifier System field can be populated in the Secondary header but
50-
** but will be ignored in the default case for SB/SBN routing purposes. It is suggested
51-
** that the CCSDS Spacecraft ID be used for that field.
52-
**
53-
** Notes: The following 4 terms have been or are used in the cFS architecture and implementation
54-
**
55-
** StreamId - First 16 bits of CCSDS Space Packet Protocol (SPP) 133.0-B.1c2 Blue Book
56-
** packet primary header. It contains the 3 bit Version Number, 1 bit Packet Type ID,
57-
** 1 bit Secondary Header flag, and 11 bit Application Process ID
58-
** It was used in earlier cFS implementaions and defined here for historical reference
59-
** It is NOT exposed to user applications.
60-
**
61-
** MsgId - Unique numeric message identifier within a mission namespace. It is used by cFS
62-
** applications to the identify messages for publishing and subscribing
63-
** It is used by the SB API and encoded in a mission defended way in the header of
64-
** all cFS messages.
65-
** It is exposed to all cFS applications
66-
**
67-
** ApId - CCSDS Application Process Id field in the primary header.
68-
** It has default bit mask of 0x07FF and is part of the cFS message Id
69-
** It should not be confused with the cFE Executive Services (ES) term appId which
70-
** identifies the software application/component
71-
** It is NOT exposed to user applications.
72-
**
73-
** MsgIdkey - This is a unique numeric key within a mission namespace that is used with
74-
** cFS software bus internal structures.
75-
** It is algorithmically created in a mission defined way from the MsgId to support
76-
** efficient lookup and mapping implementations
77-
** It is NOT exposed to user applications.
78-
**
79-
** Author: J. Wilmot/NASA
80-
**
81-
******************************************************************************/
82-
23+
** Purpose: message ID utility functions
24+
*/
8325

8426
/*
8527
** Include Files

fsw/cfe-core/src/sb/cfe_sb_verify.h

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,6 @@
3838
#error CFE_PLATFORM_SB_MAX_MSG_IDS cannot be less than 1!
3939
#endif
4040

41-
#ifndef MESSAGE_FORMAT_IS_CCSDS_VER_2
42-
#if CFE_PLATFORM_SB_MAX_MSG_IDS > 4096
43-
#error CFE_PLATFORM_SB_MAX_MSG_IDS cannot be greater than 2^12 (4096)!
44-
#endif
45-
#else
46-
#if CFE_PLATFORM_SB_MAX_MSG_IDS > 65536
47-
#error CFE_PLATFORM_SB_MAX_MSG_IDS cannot be greater than 2^16 (65536)!
48-
#endif
49-
#endif
50-
5141
#if CFE_PLATFORM_SB_MAX_PIPES < 1
5242
#error CFE_PLATFORM_SB_MAX_PIPES cannot be less than 1!
5343
#endif

fsw/cfe-core/unit-test/sb_UT.h

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ typedef struct {
8282
uint16 Tlm16Param2;
8383
} SB_UT_TstPktWoSecHdr_t;
8484

85-
#define SB_UT_CMD_MID_VALUE_BASE CFE_MISSION_CMD_MID_BASE1 + 1
86-
#define SB_UT_TLM_MID_VALUE_BASE CFE_MISSION_TLM_MID_BASE1 + 1
85+
#define SB_UT_CMD_MID_VALUE_BASE CFE_PLATFORM_CMD_MID_BASE + 1
86+
#define SB_UT_TLM_MID_VALUE_BASE CFE_PLATFORM_TLM_MID_BASE + 1
8787

8888
/* SB unit test functions */
8989
/*****************************************************************************/
@@ -3113,7 +3113,6 @@ void Test_CFE_SB_SetGetMsgId(void);
31133113
**
31143114
** \sa #UT_Text, #SB_ResetUnitTest, #CFE_SB_SetMsgId,
31153115
** \sa #CFE_SB_SetUserDataLength, #CFE_SB_GetUserDataLength,
3116-
** \sa #UT_GetActualPktLenField, #UT_Report
31173116
**
31183117
******************************************************************************/
31193118
void Test_CFE_SB_SetGetUserDataLength(void);
@@ -3133,7 +3132,6 @@ void Test_CFE_SB_SetGetUserDataLength(void);
31333132
**
31343133
** \sa #UT_Text, #SB_ResetUnitTest, #CFE_SB_SetMsgId,
31353134
** \sa #CFE_SB_SetTotalMsgLength, #CFE_SB_GetTotalMsgLength,
3136-
** \sa #UT_GetActualPktLenField, #UT_Report
31373135
**
31383136
******************************************************************************/
31393137
void Test_CFE_SB_SetGetTotalMsgLength(void);
@@ -3171,8 +3169,7 @@ void Test_CFE_SB_SetGetMsgTime(void);
31713169
** This function does not return a value.
31723170
**
31733171
** \sa #UT_Text, #SB_ResetUnitTest, #CFE_SB_SetMsgId, #CFE_SB_SetCmdCode,
3174-
** \sa #CFE_SB_GetCmdCode, #UT_GetActualCmdCodeField, #UT_DisplayPkt,
3175-
** \sa #UT_Report
3172+
** \sa #CFE_SB_GetCmdCode, #UT_DisplayPkt
31763173
**
31773174
******************************************************************************/
31783175
void Test_CFE_SB_SetGetCmdCode(void);

0 commit comments

Comments
 (0)