Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add js to check height and decide if to top is required #806

Merged

Conversation

Jh123x
Copy link
Contributor

@Jh123x Jh123x commented Feb 6, 2024

Set scroll to top element to available when page height -150 > browser height.
-150 is based on testing

Closes #772

Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for hugo-congo ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fce82b4
🔍 Latest deploy log https://app.netlify.com/sites/hugo-congo/deploys/663a4c96941a350007d966c4
😎 Deploy Preview https://deploy-preview-806--hugo-congo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jpanther
Copy link
Owner

I'm not against making this a JS feature as frankly the current implementation using only CSS is a bit hacky, but I still think it should honour the .Site.Params.footer.showScrollToTop parameter.

@Jh123x
Copy link
Contributor Author

Jh123x commented Apr 30, 2024

I'm not against making this a JS feature as frankly the current implementation using only CSS is a bit hacky, but I still think it should honour the .Site.Params.footer.showScrollToTop parameter.

Hmm, let me try it in another way

@Jh123x
Copy link
Contributor Author

Jh123x commented Apr 30, 2024

It should also obey the rule in the config now

@jpanther
Copy link
Owner

Thanks, I'll merge this in now!

@jpanther jpanther merged commit 3f7453e into jpanther:dev Aug 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

showScrollToTop and minimum 200 characters
2 participants