Skip to content
This repository has been archived by the owner on May 26, 2020. It is now read-only.

Return decoded payload in authenticate #370

Merged
merged 3 commits into from
Oct 5, 2017

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Sep 15, 2017

This allows for accessing it on request.auth easily then.

TODO:

  • test (none is failing?!)

@blueyed blueyed force-pushed the authenticate-decoded-payload branch from b8bd4a7 to 0e2f588 Compare September 15, 2017 16:28
@blueyed blueyed requested a review from jpadilla September 21, 2017 13:01
@blueyed
Copy link
Contributor Author

blueyed commented Sep 21, 2017

Should I go forward with adding a test here?

Copy link
Owner

@jpadilla jpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Some tests for this would be a good idea.

This allows for accessing it on `request.auth` easily then.
@blueyed blueyed force-pushed the authenticate-decoded-payload branch from 0e2f588 to a1584b2 Compare September 22, 2017 11:02
@blueyed
Copy link
Contributor Author

blueyed commented Sep 22, 2017

@jpadilla
Added a test, please review.

Should this be documented? Where (in general, and for the changelog)?

@blueyed blueyed force-pushed the authenticate-decoded-payload branch from 63dc76e to bbcd1a1 Compare September 22, 2017 11:21
@jpadilla
Copy link
Owner

jpadilla commented Oct 5, 2017

@blueyed I failed earlier on keeping an updated changelog so I've been just doing so on each release https://github.com/GetBlimp/django-rest-framework-jwt/releases

@blueyed blueyed merged commit 0a0bd40 into jpadilla:master Oct 5, 2017
@blueyed blueyed deleted the authenticate-decoded-payload branch October 5, 2017 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants