util: skip type checks in internal getSystemErrorName

PR-URL: nodejs#18546 Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung · Feb 22, 2018 · 8006e0b · 8006e0b
1 parent a2a2f06
commit 8006e0b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/lib/internal/util.js b/lib/internal/util.js
@@ -208,11 +208,6 @@ function getConstructorOf(obj) {
 }
 
 function getSystemErrorName(err) {
-  if (typeof err !== 'number' || err >= 0 || !Number.isSafeInteger(err)) {
-    throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'err',
-                               'negative number');
-  }
-
   const entry = errmap.get(err);
   return entry ? entry[0] : `Unknown system error ${err}`;
 }

diff --git a/lib/util.js b/lib/util.js
@@ -54,7 +54,7 @@ const {
   customInspectSymbol,
   deprecate,
   getConstructorOf,
-  getSystemErrorName,
+  getSystemErrorName: internalErrorName,
   isError,
   promisify,
   join,
@@ -1071,6 +1071,14 @@ function callbackify(original) {
   return callbackified;
 }
 
+function getSystemErrorName(err) {
+  if (typeof err !== 'number' || err >= 0 || !Number.isSafeInteger(err)) {
+    throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'err',
+                               'negative number');
+  }
+  return internalErrorName(err);
+}
+
 // Keep the `exports =` so that various functions can still be monkeypatched
 module.exports = exports = {
   _errnoException,