Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-deterministic/flaky test view::pages::manga::test::it_sends_event_chapter_bookmarked_failed_to_fetch #62

Open
youwen5 opened this issue Nov 6, 2024 · 2 comments

Comments

@youwen5
Copy link
Contributor

youwen5 commented Nov 6, 2024

The test view::pages::manga::test::it_sends_event_chapter_bookmarked_failed_to_fetch is flaky and occasionally fails when building in nixpkgs. This was not resolved by #56 and #57.

manga-tui> failures:
manga-tui>
manga-tui> ---- view::pages::manga::test::it_sends_event_chapter_bookmarked_failed_to_fetch stdout ----
manga-tui> thread 'view::pages::manga::test::it_sends_event_chapter_bookmarked_failed_to_fetch' panicked at src/backend/error_log.rs:44:64:
manga-tui> called `Result::unwrap()` on an `Err` value: Os { code: 17, kind: AlreadyExists, message: "File exists" }
manga-tui> note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
manga-tui> thread 'view::pages::manga::test::it_sends_event_chapter_bookmarked_failed_to_fetch' panicked at src/view/pages/manga.rs:1872:14:
manga-tui> called `Result::unwrap()` on an `Err` value: Elapsed(())
manga-tui>
manga-tui>
manga-tui> failures:
manga-tui>     view::pages::manga::test::it_sends_event_chapter_bookmarked_failed_to_fetch

This failure seems hard to reproduce, but it occurs (especially on lower spec machines such as low resource build servers). See NixOS/nixpkgs#353060 (comment).

@josueBarretogit
Copy link
Owner

josueBarretogit commented Nov 6, 2024

I wonder if this only happens on this test can you check by running
cargo test --no-fail-fast? to know all the the failing tests

@youwen5
Copy link
Contributor Author

youwen5 commented Nov 6, 2024

I believe is the only test that fails, I'm able to get it to build by deleting the test from the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants