Fix tests to stub the with https #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure what the difference is but my hypothesis is that the old set of stubs don't work with old docker versions (I'm on 1.6.1 currently). Could be old docker parses urls in a more naive way and forces the protocol from tcp => https. I was getting erros like: "this is stubbed" stub_request(:get, "http://tcp//example.com:5422/v1 ... "you need to stub this" stub_request(:get, "https://example.com:5422/v1 ... And note this is how the docker url is set in the helper: Docker.url = 'tcp://example.com:5422'
|
This change causes Travis to fail. Docker should not even been installed on the system for the tests to work... we are mocking out each call that should be made I am fairly sure. Also my docker version is 1.9.2. I know for a fact that Travis has no docker installed though... I still think this is some sort of system setting or version problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what the difference is but my hypothesis is that the old set of stubs don't work with old docker versions (I'm on 1.6.1 currently). Could be old docker parses urls in a more naive way and forces the protocol from tcp => https. I was getting errors like:
And note this is how the docker url is set in the helper:
Probably should not merge this if this fix doesn't work on newer docker. Might be I should just upgrade.