From a3436f15439ce36d9c4f0fc67ec3e30b3b5885d2 Mon Sep 17 00:00:00 2001 From: Gyuho Lee <6799218+gyuho@users.noreply.github.com> Date: Tue, 13 Jun 2023 12:53:40 -0700 Subject: [PATCH] snow/engine/snowman: instantiate voter after issuer (#1610) --- snow/engine/snowman/transitive.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/snow/engine/snowman/transitive.go b/snow/engine/snowman/transitive.go index 5daf34ba76fd..e6f7a45670df 100644 --- a/snow/engine/snowman/transitive.go +++ b/snow/engine/snowman/transitive.go @@ -257,6 +257,11 @@ func (t *Transitive) Chits(ctx context.Context, nodeID ids.NodeID, requestID uin zap.Stringer("nodeID", nodeID), zap.Uint32("requestID", requestID)) + added, err := t.issueFromByID(ctx, nodeID, blkID) + if err != nil { + return err + } + // Will record chits once [blkID] has been issued into consensus v := &voter{ t: t, @@ -265,10 +270,6 @@ func (t *Transitive) Chits(ctx context.Context, nodeID ids.NodeID, requestID uin response: blkID, } - added, err := t.issueFromByID(ctx, nodeID, blkID) - if err != nil { - return err - } // Wait until [blkID] has been issued to consensus before applying this chit. if !added { v.deps.Add(blkID)