Merge pull request #54 from DevFactory/release/general-code-quality-fix-2

Multiple code quality fix-2

Author: joshsh

common/src/main/java/net/fortytwo/sesametools/RdfListUtil.java

@@ -179,7 +179,7 @@ public void addListAtNode(final Resource subject,
 
         final Resource aHead = valueFactory.createBNode();
 
-        if (nextValues.size() > 0) {
+        if (!nextValues.isEmpty()) {
             graphToAddTo.add(subject, predicate, aHead, contexts);
         }
 
@@ -459,7 +459,7 @@ private List<List<Value>> getValuesForPointerTrails(
                 }
             }
 
-            if (nextResult.size() > 0) {
+            if (!nextResult.isEmpty()) {
                 results.add(nextResult);
             }
         }

common/src/main/java/net/fortytwo/sesametools/SailWriter.java

@@ -30,7 +30,7 @@ public SailWriter(final Sail sail, final Action action) {
         this.action = action;
     }
 
-    public void finalize() throws Throwable {
+    protected void finalize() throws Throwable {
         super.finalize();
 
         if (null != sailConnection) {

constrained-sail/src/main/java/net/fortytwo/sesametools/constrained/ConstrainedSail.java

@@ -91,7 +91,7 @@ public void initialize() throws SailException {
      */
     public boolean isWritable() throws SailException {
         return getBaseSail().isWritable()
-                && (writableSet.getNamedGraphs().size() > 0);  // TODO: OR the default analysis is writable
+                && (!writableSet.getNamedGraphs().isEmpty());  // TODO: OR the default analysis is writable
     }
 
     public void shutDown() throws SailException {

constrained-sail/src/main/java/net/fortytwo/sesametools/constrained/ConstrainedSailConnection.java

@@ -302,7 +302,7 @@ public void removeStatements(final Resource subj, final IRI pred, final Value ob
                     }
                 }
 
-                if (0 < toRemove.size()) {
+                if (!toRemove.isEmpty()) {
                     Resource[] ctxArray = new Resource[toRemove.size()];
                     toRemove.toArray(ctxArray);
                     super.removeStatements(subj, pred, obj, ctxArray);

rdf-transaction-sail/src/main/java/net/fortytwo/sesametools/rdftransaction/RDFTransactionSailConnection.java

@@ -59,7 +59,7 @@ public void commit() throws SailException {
     }
 
     private void commitAll() throws SailException {
-        if (0 < buffer.size()) {
+        if (!buffer.isEmpty()) {
             sail.handleTransaction(buffer);
         }
 

uri-translator/src/main/java/net/fortytwo/sesametools/URITranslator.java

@@ -157,7 +157,7 @@ public static void doTranslation(Repository repository, final String inputUriPre
 
             // add a single empty with clause if they didn't include any IRI resources as contexts
             // to make the rest of the code simpler
-            if (withClauses.size() == 0) {
+            if (withClauses.isEmpty()) {
                 withClauses.add("");
             }