Fixing squid:ClassVariableVisibilityCheck - Class variable fields should not have public accessibility.

Faisal Hameed · Faisal Hameed · commit 8f1c09d96be3 · 2016-05-31T11:36:40.000+05:00
diff --git a/replay-sail/src/main/java/net/fortytwo/sesametools/replay/RecorderSailConnection.java b/replay-sail/src/main/java/net/fortytwo/sesametools/replay/RecorderSailConnection.java
@@ -52,7 +52,7 @@ public RecorderSailConnection(final AbstractSail sail,
         super(sail);
         this.queryHandler = queryHandler;
         this.config = config;
-        if (config.logTransactions) {
+        if (config.LOG_TRANSACTIONS) {
             queryHandler.handle(new ConstructorCall(id));
         }
         this.baseSailConnection = baseSail.getConnection();
@@ -64,7 +64,7 @@ protected void addStatementInternal(final Resource subj,
                              final IRI pred,
                              final Value obj,
                              final Resource... contexts) throws SailException {
-        if (config.logWriteOperations) {
+        if (config.LOG_WRITE_OPERATIONS) {
             queryHandler.handle(new AddStatementCall(id, subj, pred, obj, contexts));
         }
         baseSailConnection.addStatement(subj, pred, obj, contexts);
@@ -73,28 +73,28 @@ protected void addStatementInternal(final Resource subj,
     // Note: clearing statements does not change the configuration of cached
     // values.
     protected void clearInternal(final Resource... contexts) throws SailException {
-        if (config.logWriteOperations) {
+        if (config.LOG_WRITE_OPERATIONS) {
             queryHandler.handle(new ClearCall(id, contexts));
         }
         baseSailConnection.clear(contexts);
     }
 
     protected void clearNamespacesInternal() throws SailException {
-        if (config.logWriteOperations) {
+        if (config.LOG_WRITE_OPERATIONS) {
             queryHandler.handle(new ClearNamespacesCall(id));
         }
         baseSailConnection.clearNamespaces();
     }
 
     protected void closeInternal() throws SailException {
-        if (config.logTransactions) {
+        if (config.LOG_TRANSACTIONS) {
             queryHandler.handle(new CloseConnectionCall(id));
         }
         baseSailConnection.close();
     }
 
     protected void commitInternal() throws SailException {
-        if (config.logTransactions) {
+        if (config.LOG_TRANSACTIONS) {
             queryHandler.handle(new CommitCall(id));
         }
         baseSailConnection.commit();
@@ -104,15 +104,15 @@ protected CloseableIteration<? extends BindingSet, QueryEvaluationException> eva
             final TupleExpr tupleExpr, final Dataset dataSet, final BindingSet bindingSet, final boolean includeInferred)
             throws SailException {
         // Note: there is no recording iterator for evaluate() results
-        if (config.logReadOperations) {
+        if (config.LOG_READ_OPERATIONS) {
             queryHandler.handle(new EvaluateCall(id, includeInferred));
         }
         return baseSailConnection.evaluate(tupleExpr, dataSet, bindingSet, includeInferred);
     }
 
     protected CloseableIteration<? extends Resource, SailException> getContextIDsInternal()
             throws SailException {
-        if (config.logReadOperations) {
+        if (config.LOG_READ_OPERATIONS) {
             queryHandler.handle(new GetContextIDsCall(id));
             return new RecorderIteration<>(
                     (CloseableIteration<Resource, SailException>) baseSailConnection.getContextIDs(),
@@ -129,15 +129,15 @@ private String nextIterationId() {
     }
 
     protected String getNamespaceInternal(final String prefix) throws SailException {
-        if (config.logReadOperations) {
+        if (config.LOG_READ_OPERATIONS) {
             queryHandler.handle(new GetNamespaceCall(id, prefix));
         }
         return baseSailConnection.getNamespace(prefix);
     }
 
     protected CloseableIteration<? extends Namespace, SailException> getNamespacesInternal()
             throws SailException {
-        if (config.logReadOperations) {
+        if (config.LOG_READ_OPERATIONS) {
             queryHandler.handle(new GetNamespacesCall(id));
             return new RecorderIteration<>(
                     (CloseableIteration<Namespace, SailException>) baseSailConnection.getNamespaces(),
@@ -152,7 +152,7 @@ protected CloseableIteration<? extends Statement, SailException> getStatementsIn
             final Resource subj, final IRI pred, final Value obj, final boolean includeInferred,
             final Resource... contexts) throws SailException {
 
-        if (config.logReadOperations) {
+        if (config.LOG_READ_OPERATIONS) {
             queryHandler.handle(new GetStatementsCall(id, subj, pred, obj, includeInferred, contexts));
             return new RecorderIteration<>(
                     (CloseableIteration<Statement, SailException>) baseSailConnection.getStatements(
@@ -165,7 +165,7 @@ protected CloseableIteration<? extends Statement, SailException> getStatementsIn
     }
 
     protected void removeNamespaceInternal(final String prefix) throws SailException {
-        if (config.logWriteOperations) {
+        if (config.LOG_WRITE_OPERATIONS) {
             queryHandler.handle(new RemoveNamespaceCall(id, prefix));
         }
         baseSailConnection.removeNamespace(prefix);
@@ -175,35 +175,35 @@ protected void removeStatementsInternal(final Resource subj,
                                  final IRI pred,
                                  final Value obj,
                                  final Resource... contexts) throws SailException {
-        if (config.logWriteOperations) {
+        if (config.LOG_WRITE_OPERATIONS) {
             queryHandler.handle(new RemoveStatementsCall(id, subj, pred, obj, contexts));
         }
         baseSailConnection.removeStatements(subj, pred, obj, contexts);
     }
 
     protected void rollbackInternal() throws SailException {
-        if (config.logTransactions) {
+        if (config.LOG_TRANSACTIONS) {
             queryHandler.handle(new RollbackCall(id));
         }
         baseSailConnection.rollback();
     }
 
     protected void setNamespaceInternal(final String prefix, final String name) throws SailException {
-        if (config.logWriteOperations) {
+        if (config.LOG_WRITE_OPERATIONS) {
             queryHandler.handle(new SetNamespaceCall(id, prefix, name));
         }
         baseSailConnection.setNamespace(prefix, name);
     }
 
     protected long sizeInternal(final Resource... contexts) throws SailException {
-        if (config.logReadOperations) {
+        if (config.LOG_READ_OPERATIONS) {
             queryHandler.handle(new SizeCall(id, contexts));
         }
         return baseSailConnection.size(contexts);
     }
 
     protected void startTransactionInternal() throws SailException {
-        if (config.logTransactions) {
+        if (config.LOG_TRANSACTIONS) {
             queryHandler.handle(new BeginCall(id));
         }
         baseSailConnection.begin();
diff --git a/replay-sail/src/main/java/net/fortytwo/sesametools/replay/ReplayConfiguration.java b/replay-sail/src/main/java/net/fortytwo/sesametools/replay/ReplayConfiguration.java
@@ -4,7 +4,7 @@
  * @author Joshua Shinavier (http://fortytwo.net).
  */
 public class ReplayConfiguration {
-    public boolean logTransactions = true;
-    public boolean logReadOperations = true;
-    public boolean logWriteOperations = true;
+    public static final boolean LOG_TRANSACTIONS = true;
+    public static final boolean LOG_READ_OPERATIONS = true;
+    public static final boolean LOG_WRITE_OPERATIONS = true;
 }

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public RecorderSailConnection(final AbstractSail sail,`
`52`	`52`	`super(sail);`
`53`	`53`	`this.queryHandler = queryHandler;`
`54`	`54`	`this.config = config;`
`55`		`- if (config.logTransactions) {`
	`55`	`+ if (config.LOG_TRANSACTIONS) {`
`56`	`56`	`queryHandler.handle(new ConstructorCall(id));`
`57`	`57`	`}`
`58`	`58`	`this.baseSailConnection = baseSail.getConnection();`
`@@ -64,7 +64,7 @@ protected void addStatementInternal(final Resource subj,`
`64`	`64`	`final IRI pred,`
`65`	`65`	`final Value obj,`
`66`	`66`	`final Resource... contexts) throws SailException {`
`67`		`- if (config.logWriteOperations) {`
	`67`	`+ if (config.LOG_WRITE_OPERATIONS) {`
`68`	`68`	`queryHandler.handle(new AddStatementCall(id, subj, pred, obj, contexts));`
`69`	`69`	`}`
`70`	`70`	`baseSailConnection.addStatement(subj, pred, obj, contexts);`
`@@ -73,28 +73,28 @@ protected void addStatementInternal(final Resource subj,`
`73`	`73`	`// Note: clearing statements does not change the configuration of cached`
`74`	`74`	`// values.`
`75`	`75`	`protected void clearInternal(final Resource... contexts) throws SailException {`
`76`		`- if (config.logWriteOperations) {`
	`76`	`+ if (config.LOG_WRITE_OPERATIONS) {`
`77`	`77`	`queryHandler.handle(new ClearCall(id, contexts));`
`78`	`78`	`}`
`79`	`79`	`baseSailConnection.clear(contexts);`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`protected void clearNamespacesInternal() throws SailException {`
`83`		`- if (config.logWriteOperations) {`
	`83`	`+ if (config.LOG_WRITE_OPERATIONS) {`
`84`	`84`	`queryHandler.handle(new ClearNamespacesCall(id));`
`85`	`85`	`}`
`86`	`86`	`baseSailConnection.clearNamespaces();`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`protected void closeInternal() throws SailException {`
`90`		`- if (config.logTransactions) {`
	`90`	`+ if (config.LOG_TRANSACTIONS) {`
`91`	`91`	`queryHandler.handle(new CloseConnectionCall(id));`
`92`	`92`	`}`
`93`	`93`	`baseSailConnection.close();`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`protected void commitInternal() throws SailException {`
`97`		`- if (config.logTransactions) {`
	`97`	`+ if (config.LOG_TRANSACTIONS) {`
`98`	`98`	`queryHandler.handle(new CommitCall(id));`
`99`	`99`	`}`
`100`	`100`	`baseSailConnection.commit();`
`@@ -104,15 +104,15 @@ protected CloseableIteration<? extends BindingSet, QueryEvaluationException> eva`
`104`	`104`	`final TupleExpr tupleExpr, final Dataset dataSet, final BindingSet bindingSet, final boolean includeInferred)`
`105`	`105`	`throws SailException {`
`106`	`106`	`// Note: there is no recording iterator for evaluate() results`
`107`		`- if (config.logReadOperations) {`
	`107`	`+ if (config.LOG_READ_OPERATIONS) {`
`108`	`108`	`queryHandler.handle(new EvaluateCall(id, includeInferred));`
`109`	`109`	`}`
`110`	`110`	`return baseSailConnection.evaluate(tupleExpr, dataSet, bindingSet, includeInferred);`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`protected CloseableIteration<? extends Resource, SailException> getContextIDsInternal()`
`114`	`114`	`throws SailException {`
`115`		`- if (config.logReadOperations) {`
	`115`	`+ if (config.LOG_READ_OPERATIONS) {`
`116`	`116`	`queryHandler.handle(new GetContextIDsCall(id));`
`117`	`117`	`return new RecorderIteration<>(`
`118`	`118`	`(CloseableIteration<Resource, SailException>) baseSailConnection.getContextIDs(),`
`@@ -129,15 +129,15 @@ private String nextIterationId() {`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`protected String getNamespaceInternal(final String prefix) throws SailException {`
`132`		`- if (config.logReadOperations) {`
	`132`	`+ if (config.LOG_READ_OPERATIONS) {`
`133`	`133`	`queryHandler.handle(new GetNamespaceCall(id, prefix));`
`134`	`134`	`}`
`135`	`135`	`return baseSailConnection.getNamespace(prefix);`
`136`	`136`	`}`
`137`	`137`
`138`	`138`	`protected CloseableIteration<? extends Namespace, SailException> getNamespacesInternal()`
`139`	`139`	`throws SailException {`
`140`		`- if (config.logReadOperations) {`
	`140`	`+ if (config.LOG_READ_OPERATIONS) {`
`141`	`141`	`queryHandler.handle(new GetNamespacesCall(id));`
`142`	`142`	`return new RecorderIteration<>(`
`143`	`143`	`(CloseableIteration<Namespace, SailException>) baseSailConnection.getNamespaces(),`
`@@ -152,7 +152,7 @@ protected CloseableIteration<? extends Statement, SailException> getStatementsIn`
`152`	`152`	`final Resource subj, final IRI pred, final Value obj, final boolean includeInferred,`
`153`	`153`	`final Resource... contexts) throws SailException {`
`154`	`154`
`155`		`- if (config.logReadOperations) {`
	`155`	`+ if (config.LOG_READ_OPERATIONS) {`
`156`	`156`	`queryHandler.handle(new GetStatementsCall(id, subj, pred, obj, includeInferred, contexts));`
`157`	`157`	`return new RecorderIteration<>(`
`158`	`158`	`(CloseableIteration<Statement, SailException>) baseSailConnection.getStatements(`
`@@ -165,7 +165,7 @@ protected CloseableIteration<? extends Statement, SailException> getStatementsIn`
`165`	`165`	`}`
`166`	`166`
`167`	`167`	`protected void removeNamespaceInternal(final String prefix) throws SailException {`
`168`		`- if (config.logWriteOperations) {`
	`168`	`+ if (config.LOG_WRITE_OPERATIONS) {`
`169`	`169`	`queryHandler.handle(new RemoveNamespaceCall(id, prefix));`
`170`	`170`	`}`
`171`	`171`	`baseSailConnection.removeNamespace(prefix);`
`@@ -175,35 +175,35 @@ protected void removeStatementsInternal(final Resource subj,`
`175`	`175`	`final IRI pred,`
`176`	`176`	`final Value obj,`
`177`	`177`	`final Resource... contexts) throws SailException {`
`178`		`- if (config.logWriteOperations) {`
	`178`	`+ if (config.LOG_WRITE_OPERATIONS) {`
`179`	`179`	`queryHandler.handle(new RemoveStatementsCall(id, subj, pred, obj, contexts));`
`180`	`180`	`}`
`181`	`181`	`baseSailConnection.removeStatements(subj, pred, obj, contexts);`
`182`	`182`	`}`
`183`	`183`
`184`	`184`	`protected void rollbackInternal() throws SailException {`
`185`		`- if (config.logTransactions) {`
	`185`	`+ if (config.LOG_TRANSACTIONS) {`
`186`	`186`	`queryHandler.handle(new RollbackCall(id));`
`187`	`187`	`}`
`188`	`188`	`baseSailConnection.rollback();`
`189`	`189`	`}`
`190`	`190`
`191`	`191`	`protected void setNamespaceInternal(final String prefix, final String name) throws SailException {`
`192`		`- if (config.logWriteOperations) {`
	`192`	`+ if (config.LOG_WRITE_OPERATIONS) {`
`193`	`193`	`queryHandler.handle(new SetNamespaceCall(id, prefix, name));`
`194`	`194`	`}`
`195`	`195`	`baseSailConnection.setNamespace(prefix, name);`
`196`	`196`	`}`
`197`	`197`
`198`	`198`	`protected long sizeInternal(final Resource... contexts) throws SailException {`
`199`		`- if (config.logReadOperations) {`
	`199`	`+ if (config.LOG_READ_OPERATIONS) {`
`200`	`200`	`queryHandler.handle(new SizeCall(id, contexts));`
`201`	`201`	`}`
`202`	`202`	`return baseSailConnection.size(contexts);`
`203`	`203`	`}`
`204`	`204`
`205`	`205`	`protected void startTransactionInternal() throws SailException {`
`206`		`- if (config.logTransactions) {`
	`206`	`+ if (config.LOG_TRANSACTIONS) {`
`207`	`207`	`queryHandler.handle(new BeginCall(id));`
`208`	`208`	`}`
`209`	`209`	`baseSailConnection.begin();`