Feature: add option for alternate shell icon

[zatchheems]

Alternate Shell Icon Feature

For some odd reason, the NerdFont icon nf-dev-terminal renders strangely when windows running shells are focused. It could be Kitty, it could be my theme; I've tried several different NerdFont options to no avail. Not sure what the problem is or if it's repeatable. I've added an option to change this icon from black-on-white to white-on-black, which renders correctly and looks quite a bit better on my machine, regardless of the weird focus problem.

I'm also thinking about adding a small preview for the icon difference in the README but I'm not sure if that's necessary. Please advise!

Demo:

Detail:

[joshmedeski]

Thanks for doing this! I'm thinking of offering a yml file or something so people can map whatever icons they want to whatever values, but this is helpful for now.

I've made a couple of suggestions to make it more flexible and cleanup the code.

[joshmedeski]

How about we accept a string to let people pick whatever icon they want?

Suggested change

	set -g @tmux-nerd-font-window-name-alterate-shell-icon true
	set -g @tmux-nerd-font-window-name-shell-icon ""

[joshmedeski]

I prefer we use a function to scope the data.

get_shell_icon() {
	local default_shell_icon=''
	local shell_icon="$(tmux show -gqv '@tmux-nerd-font-window-name-shell-icon')"
	[ -n "$shell_icon" ] && echo "$shell_icon" || echo "$default_shell_icon"
}

SHELL_ICON=$(get_shell_icon)

Please test this and clean it up as you see fit.

[zatchheems]

thanks for the suggestions! I appreciate them especially because tmux config and plugins can get spaghetti-like without constant vigilance 🙂

I'll make those changes and test sometime today or tomorrow scratch that, found some time.

[zatchheems]

This differs from your suggestion, but I usually prefer verbosity over shorthand—it's a holdover from a few years in Rescript I think. I can use shorthand if preferred.

[joshmedeski]

Looks good to me 👍

[zatchheems]

This is already merged, but just for future reference: applying bold styling to NerdFonts can cause them to behave unexpectedly. That's what caused the weird behavior in my screenshots.

The more you know!

[joshmedeski]

Good to know, I might add some info to the README to let people know.