refactor: remove error handler

Closes #10

Author: josantonius

src/Cookie.php

@@ -41,7 +41,7 @@ class Cookie
      * @see https://www.php.net/manual/en/datetime.formats.php
      * @see https://www.php.net/manual/en/function.setcookie.php
      *
-     * @throws CookieException if $sameSite value is wrong
+     * @throws CookieException if $sameSite value is wrong.
      */
     public function __construct(
         private string $domain = '',
@@ -52,12 +52,7 @@ public function __construct(
         private null|string $sameSite = null,
         private bool $secure = false,
     ) {
-        $this->failIfSameSiteValueIsWrong();
-
-        set_error_handler(
-            fn (int $severity, string $message, string $file) =>
-            $file === __FILE__ && throw new CookieException($message)
-        );
+        $this->throwExceptionIfSameSiteValueIsWrong();
     }
 
     /**
@@ -97,11 +92,13 @@ public function get(string $name, mixed $default = null): mixed
      *
      * @see https://www.php.net/manual/en/datetime.formats.php
      *
-     * @throws CookieException if headers already sent
-     * @throws CookieException if failure in date/time string analysis
+     * @throws CookieException if headers already sent.
+     * @throws CookieException if failure in date/time string analysis.
      */
     public function set(string $name, mixed $value, null|int|string|DateTime $expires = null): void
     {
+        $this->throwExceptionIfHeadersWereSent();
+
         $params = [$name, $value, $this->getOptions($expires === null ? $this->expires : $expires)];
 
         $this->raw ? setrawcookie(...$params) : setcookie(...$params);
@@ -119,10 +116,12 @@ public function set(string $name, mixed $value, null|int|string|DateTime $expire
      *
      * @see https://www.php.net/manual/en/datetime.formats.php
      *
-     * @throws CookieException if headers already sent
+     * @throws CookieException if headers already sent.
      */
     public function replace(array $data, null|int|string|DateTime $expires = null): void
     {
+        $this->throwExceptionIfHeadersWereSent();
+
         foreach ($data as $name => $value) {
             $this->set($name, $value, $expires);
         }
@@ -133,10 +132,12 @@ public function replace(array $data, null|int|string|DateTime $expires = null):
      *
      * Optionally defines a default value when the cookie does not exist.
      *
-     * @throws CookieException if headers already sent
+     * @throws CookieException if headers already sent.
      */
     public function pull(string $name, mixed $default = null): mixed
     {
+        $this->throwExceptionIfHeadersWereSent();
+
         $value = $_COOKIE[$name] ?? $default;
 
         $this->remove($name);
@@ -147,11 +148,13 @@ public function pull(string $name, mixed $default = null): mixed
     /**
      * Deletes a cookie by name.
      *
-     * @throws CookieException if headers already sent
-     * @throws CookieException if failure in date/time string analysis
+     * @throws CookieException if headers already sent.
+     * @throws CookieException if failure in date/time string analysis.
      */
     public function remove(string $name): void
     {
+        $this->throwExceptionIfHeadersWereSent();
+
         $params = [$name, '', $this->getOptions(1, false)];
 
         $this->raw ? setrawcookie(...$params) : setcookie(...$params);
@@ -160,10 +163,12 @@ public function remove(string $name): void
     /**
      * Deletes all cookies.
      *
-     * @throws CookieException if headers already sent
+     * @throws CookieException if headers already sent.
      */
     public function clear(): void
     {
+        $this->throwExceptionIfHeadersWereSent();
+
         foreach ($_COOKIE ?? [] as $name) {
             $this->remove($name);
         }
@@ -172,7 +177,7 @@ public function clear(): void
     /**
      * Gets cookie options.
      *
-     * @throws CookieException if failure in date/time string analysis
+     * @throws CookieException if failure in date/time string analysis.
      */
     private function getOptions(null|int|string|DateTime $expires, bool $formatTime = true): array
     {
@@ -198,7 +203,7 @@ private function getOptions(null|int|string|DateTime $expires, bool $formatTime
     /**
      * Format the expiration time.
      *
-     * @throws CookieException if failure in date/time string analysis
+     * @throws CookieException if failure in date/time string analysis.
      */
     private function formatExpirationTime(int|string|DateTime $expires): int
     {
@@ -215,12 +220,26 @@ private function formatExpirationTime(int|string|DateTime $expires): int
         }
     }
 
+    /**
+     * Throw exception if headers have already been sent.
+     *
+     * @throws CookieException if headers already sent.
+     */
+    private function throwExceptionIfHeadersWereSent(): void
+    {
+        headers_sent($file, $line) && throw new CookieException(sprintf(
+            'The headers have already been sent in "%s" at line %d.',
+            $file,
+            $line
+        ));
+    }
+
     /**
      * Throw exception if $sameSite value is wrong.
      *
-     * @throws CookieException if $sameSite value is wrong
+     * @throws CookieException if $sameSite value is wrong.
      */
-    private function failIfSameSiteValueIsWrong(): void
+    private function throwExceptionIfSameSiteValueIsWrong(): void
     {
         $values = ['none', 'lax', 'strict'];
 

src/Facades/Cookie.php

@@ -14,6 +14,7 @@
 namespace Josantonius\Cookie\Facades;
 
 use Josantonius\Cookie\Cookie as CookieInstance;
+use Josantonius\Cookie\Exceptions\CookieException;
 
 /**
  * Cookie handler with static methods.
@@ -50,7 +51,7 @@ private static function getInstance()
      * @see https://www.php.net/manual/en/datetime.formats.php
      * @see https://www.php.net/manual/en/function.setcookie.php
      *
-     * @throws CookieException if $sameSite value is wrong
+     * @throws CookieException if $sameSite value is wrong.
      */
     public static function options(
         string $domain = '',
@@ -107,7 +108,7 @@ public function get(string $name, mixed $default = null): mixed
      *
      * @see https://www.php.net/manual/en/datetime.formats.php
      *
-     * @throws CookieException if headers already sent
+     * @throws CookieException if headers already sent.
      */
     public function set(string $name, mixed $value, null|int|DateTime $expires = null): void
     {
@@ -126,7 +127,7 @@ public function set(string $name, mixed $value, null|int|DateTime $expires = nul
      *
      * @see https://www.php.net/manual/en/datetime.formats.php
      *
-     * @throws CookieException if headers already sent
+     * @throws CookieException if headers already sent.
      */
     public function replace(array $data, null|int|DateTime $expires = null): void
     {
@@ -138,7 +139,7 @@ public function replace(array $data, null|int|DateTime $expires = null): void
      *
      * Optionally defines a default value when the cookie does not exist.
      *
-     * @throws CookieException if headers already sent
+     * @throws CookieException if headers already sent.
      */
     public function pull(string $name, mixed $default = null): mixed
     {
@@ -148,7 +149,7 @@ public function pull(string $name, mixed $default = null): mixed
     /**
      * Deletes a cookie by name.
      *
-     * @throws CookieException if headers already sent
+     * @throws CookieException if headers already sent.
      */
     public function remove(string $name): void
     {
@@ -158,7 +159,7 @@ public function remove(string $name): void
     /**
      * Deletes all cookies.
      *
-     * @throws CookieException if headers already sent
+     * @throws CookieException if headers already sent.
      */
     public function clear(): void
     {