This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Revert "MutableDictionaryArray rewrite: use values stored in the array instead of the hash->hash map" #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1559 +/- ##
==========================================
+ Coverage 82.95% 83.08% +0.12%
==========================================
Files 391 389 -2
Lines 42809 42640 -169
==========================================
- Hits 35512 35426 -86
+ Misses 7297 7214 -83
☔ View full report in Codecov by Sentry. |
aldanor
added a commit
to aldanor/arrow2
that referenced
this pull request
Sep 3, 2023
…the array instead of the hash->hash map" (jorgecarleitao#1559)" This reverts commit b2017d7.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1555
This added a lot of unsafe code that I don't think we need (and miri is not happy). I put this revert ready to get the discussion going.