feat: remove python-dateutil dependency (hetznercloud#221)

jooola · web-flow · commit 8ea4aa0ad12e · 2023-06-23T16:41:06.000+02:00
* refactor: replace pytz tzoffset with timezone utc

* refactor: replace isoparse with datetime.fromisoformat

* feat: remove python-dateutil dependency
diff --git a/hcloud/actions/domain.py b/hcloud/actions/domain.py
@@ -1,4 +1,4 @@
-from dateutil.parser import isoparse
+from datetime import datetime
 
 from hcloud.core.domain import BaseDomain
 
@@ -52,8 +52,8 @@ def __init__(
 
         self.status = status
         self.progress = progress
-        self.started = isoparse(started) if started else None
-        self.finished = isoparse(finished) if finished else None
+        self.started = datetime.fromisoformat(started) if started else None
+        self.finished = datetime.fromisoformat(finished) if finished else None
         self.resources = resources
         self.error = error
 
diff --git a/hcloud/certificates/domain.py b/hcloud/certificates/domain.py
@@ -1,4 +1,4 @@
-from dateutil.parser import isoparse
+from datetime import datetime
 
 from hcloud.core.domain import BaseDomain, DomainIdentityMixin
 
@@ -59,9 +59,13 @@ def __init__(
         self.certificate = certificate
         self.domain_names = domain_names
         self.fingerprint = fingerprint
-        self.not_valid_before = isoparse(not_valid_before) if not_valid_before else None
-        self.not_valid_after = isoparse(not_valid_after) if not_valid_after else None
-        self.created = isoparse(created) if created else None
+        self.not_valid_before = (
+            datetime.fromisoformat(not_valid_before) if not_valid_before else None
+        )
+        self.not_valid_after = (
+            datetime.fromisoformat(not_valid_after) if not_valid_after else None
+        )
+        self.created = datetime.fromisoformat(created) if created else None
         self.labels = labels
         self.status = status
 
diff --git a/hcloud/deprecation/domain.py b/hcloud/deprecation/domain.py
@@ -1,4 +1,4 @@
-from dateutil.parser import isoparse
+from datetime import datetime
 
 from hcloud.core.domain import BaseDomain
 
@@ -25,7 +25,7 @@ def __init__(
         announced=None,
         unavailable_after=None,
     ):
-        self.announced = isoparse(announced) if announced else None
+        self.announced = datetime.fromisoformat(announced) if announced else None
         self.unavailable_after = (
-            isoparse(unavailable_after) if unavailable_after else None
+            datetime.fromisoformat(unavailable_after) if unavailable_after else None
         )
diff --git a/hcloud/firewalls/domain.py b/hcloud/firewalls/domain.py
@@ -1,4 +1,4 @@
-from dateutil.parser import isoparse
+from datetime import datetime
 
 from hcloud.core.domain import BaseDomain
 
@@ -30,7 +30,7 @@ def __init__(
         self.rules = rules
         self.applied_to = applied_to
         self.labels = labels
-        self.created = isoparse(created) if created else None
+        self.created = datetime.fromisoformat(created) if created else None
 
 
 class FirewallRule:
diff --git a/hcloud/floating_ips/domain.py b/hcloud/floating_ips/domain.py
@@ -1,4 +1,4 @@
-from dateutil.parser import isoparse
+from datetime import datetime
 
 from hcloud.core.domain import BaseDomain
 
@@ -72,7 +72,7 @@ def __init__(
         self.blocked = blocked
         self.protection = protection
         self.labels = labels
-        self.created = isoparse(created) if created else None
+        self.created = datetime.fromisoformat(created) if created else None
         self.name = name
 
 
diff --git a/hcloud/images/domain.py b/hcloud/images/domain.py
@@ -1,4 +1,4 @@
-from dateutil.parser import isoparse
+from datetime import datetime
 
 from hcloud.core.domain import BaseDomain, DomainIdentityMixin
 
@@ -85,11 +85,11 @@ def __init__(
         self.id = id
         self.name = name
         self.type = type
-        self.created = isoparse(created) if created else None
+        self.created = datetime.fromisoformat(created) if created else None
         self.description = description
         self.image_size = image_size
         self.disk_size = disk_size
-        self.deprecated = isoparse(deprecated) if deprecated else None
+        self.deprecated = datetime.fromisoformat(deprecated) if deprecated else None
         self.bound_to = bound_to
         self.os_flavor = os_flavor
         self.os_version = os_version
diff --git a/hcloud/isos/domain.py b/hcloud/isos/domain.py
@@ -1,4 +1,4 @@
-from dateutil.parser import isoparse
+from datetime import datetime
 
 from hcloud.core.domain import BaseDomain, DomainIdentityMixin
 
@@ -36,4 +36,4 @@ def __init__(
         self.type = type
         self.architecture = architecture
         self.description = description
-        self.deprecated = isoparse(deprecated) if deprecated else None
+        self.deprecated = datetime.fromisoformat(deprecated) if deprecated else None
diff --git a/hcloud/load_balancers/domain.py b/hcloud/load_balancers/domain.py
@@ -1,4 +1,4 @@
-from dateutil.parser import isoparse
+from datetime import datetime
 
 from hcloud.core.domain import BaseDomain
 
@@ -76,7 +76,7 @@ def __init__(
     ):
         self.id = id
         self.name = name
-        self.created = isoparse(created) if created else None
+        self.created = datetime.fromisoformat(created) if created else None
         self.public_net = public_net
         self.private_net = private_net
         self.location = location
diff --git a/hcloud/networks/domain.py b/hcloud/networks/domain.py
@@ -1,4 +1,4 @@
-from dateutil.parser import isoparse
+from datetime import datetime
 
 from hcloud.core.domain import BaseDomain
 
@@ -54,7 +54,7 @@ def __init__(
     ):
         self.id = id
         self.name = name
-        self.created = isoparse(created) if created else None
+        self.created = datetime.fromisoformat(created) if created else None
         self.ip_range = ip_range
         self.subnets = subnets
         self.routes = routes
diff --git a/hcloud/placement_groups/domain.py b/hcloud/placement_groups/domain.py
@@ -1,4 +1,4 @@
-from dateutil.parser import isoparse
+from datetime import datetime
 
 from hcloud.core.domain import BaseDomain
 
@@ -35,7 +35,7 @@ def __init__(
         self.labels = labels
         self.servers = servers
         self.type = type
-        self.created = isoparse(created) if created else None
+        self.created = datetime.fromisoformat(created) if created else None
 
 
 class CreatePlacementGroupResponse(BaseDomain):
diff --git a/hcloud/primary_ips/domain.py b/hcloud/primary_ips/domain.py
@@ -1,4 +1,4 @@
-from dateutil.parser import isoparse
+from datetime import datetime
 
 from hcloud.core.domain import BaseDomain
 
@@ -74,7 +74,7 @@ def __init__(
         self.blocked = blocked
         self.protection = protection
         self.labels = labels
-        self.created = isoparse(created) if created else None
+        self.created = datetime.fromisoformat(created) if created else None
         self.name = name
         self.assignee_id = assignee_id
         self.assignee_type = assignee_type
diff --git a/hcloud/servers/domain.py b/hcloud/servers/domain.py
@@ -1,4 +1,4 @@
-from dateutil.parser import isoparse
+from datetime import datetime
 
 from hcloud.core.domain import BaseDomain
 
@@ -113,7 +113,7 @@ def __init__(
         self.id = id
         self.name = name
         self.status = status
-        self.created = isoparse(created) if created else None
+        self.created = datetime.fromisoformat(created) if created else None
         self.public_net = public_net
         self.server_type = server_type
         self.datacenter = datacenter
diff --git a/hcloud/ssh_keys/domain.py b/hcloud/ssh_keys/domain.py
@@ -1,4 +1,4 @@
-from dateutil.parser import isoparse
+from datetime import datetime
 
 from hcloud.core.domain import BaseDomain, DomainIdentityMixin
 
@@ -36,4 +36,4 @@ def __init__(
         self.fingerprint = fingerprint
         self.public_key = public_key
         self.labels = labels
-        self.created = isoparse(created) if created else None
+        self.created = datetime.fromisoformat(created) if created else None
diff --git a/hcloud/volumes/domain.py b/hcloud/volumes/domain.py
@@ -1,4 +1,4 @@
-from dateutil.parser import isoparse
+from datetime import datetime
 
 from hcloud.core.domain import BaseDomain, DomainIdentityMixin
 
@@ -66,7 +66,7 @@ def __init__(
         self.id = id
         self.name = name
         self.server = server
-        self.created = isoparse(created) if created else None
+        self.created = datetime.fromisoformat(created) if created else None
         self.location = location
         self.size = size
         self.linux_device = linux_device
diff --git a/setup.py b/setup.py
@@ -37,7 +37,6 @@
     ],
     python_requires=">=3.7",
     install_requires=[
-        "python-dateutil>=2.7.5",
         "requests>=2.20",
     ],
     extras_require={
diff --git a/tests/unit/actions/test_domain.py b/tests/unit/actions/test_domain.py
@@ -1,6 +1,5 @@
 import datetime
-
-from dateutil.tz import tzoffset
+from datetime import timezone
 
 from hcloud.actions.domain import Action
 
@@ -11,8 +10,8 @@ def test_started_finished_is_datetime(self):
             id=1, started="2016-01-30T23:50+00:00", finished="2016-03-30T23:50+00:00"
         )
         assert action.started == datetime.datetime(
-            2016, 1, 30, 23, 50, tzinfo=tzoffset(None, 0)
+            2016, 1, 30, 23, 50, tzinfo=timezone.utc
         )
         assert action.finished == datetime.datetime(
-            2016, 3, 30, 23, 50, tzinfo=tzoffset(None, 0)
+            2016, 3, 30, 23, 50, tzinfo=timezone.utc
         )
diff --git a/tests/unit/certificates/test_domain.py b/tests/unit/certificates/test_domain.py
@@ -1,6 +1,5 @@
 import datetime
-
-from dateutil.tz import tzoffset
+from datetime import timezone
 
 from hcloud.certificates.domain import Certificate
 
@@ -14,11 +13,11 @@ def test_created_is_datetime(self):
             not_valid_before="2016-01-30T23:50+00:00",
         )
         assert certificate.created == datetime.datetime(
-            2016, 1, 30, 23, 50, tzinfo=tzoffset(None, 0)
+            2016, 1, 30, 23, 50, tzinfo=timezone.utc
         )
         assert certificate.not_valid_after == datetime.datetime(
-            2016, 1, 30, 23, 50, tzinfo=tzoffset(None, 0)
+            2016, 1, 30, 23, 50, tzinfo=timezone.utc
         )
         assert certificate.not_valid_before == datetime.datetime(
-            2016, 1, 30, 23, 50, tzinfo=tzoffset(None, 0)
+            2016, 1, 30, 23, 50, tzinfo=timezone.utc
         )
diff --git a/tests/unit/core/test_domain.py b/tests/unit/core/test_domain.py
@@ -1,5 +1,6 @@
+from datetime import datetime
+
 import pytest
-from dateutil.parser import isoparse
 
 from hcloud.core.domain import (
     BaseDomain,
@@ -101,7 +102,7 @@ class ActionDomain(BaseDomain, DomainIdentityMixin):
     def __init__(self, id, name="name1", started=None):
         self.id = id
         self.name = name
-        self.started = isoparse(started) if started else None
+        self.started = datetime.fromisoformat(started) if started else None
 
 
 class TestBaseDomain:
@@ -125,7 +126,7 @@ class TestBaseDomain:
                 {
                     "id": 4,
                     "name": "name-name3",
-                    "started": isoparse("2016-01-30T23:50+00:00"),
+                    "started": datetime.fromisoformat("2016-01-30T23:50+00:00"),
                 },
             ),
         ],
diff --git a/tests/unit/firewalls/test_domain.py b/tests/unit/firewalls/test_domain.py
@@ -1,6 +1,5 @@
 import datetime
-
-from dateutil.tz import tzoffset
+from datetime import timezone
 
 from hcloud.firewalls.domain import Firewall
 
@@ -9,5 +8,5 @@ class TestFirewall:
     def test_created_is_datetime(self):
         firewall = Firewall(id=1, created="2016-01-30T23:50+00:00")
         assert firewall.created == datetime.datetime(
-            2016, 1, 30, 23, 50, tzinfo=tzoffset(None, 0)
+            2016, 1, 30, 23, 50, tzinfo=timezone.utc
         )
diff --git a/tests/unit/floating_ips/test_domain.py b/tests/unit/floating_ips/test_domain.py
@@ -1,6 +1,5 @@
 import datetime
-
-from dateutil.tz import tzoffset
+from datetime import timezone
 
 from hcloud.floating_ips.domain import FloatingIP
 
@@ -9,5 +8,5 @@ class TestFloatingIP:
     def test_created_is_datetime(self):
         floatingIP = FloatingIP(id=1, created="2016-01-30T23:50+00:00")
         assert floatingIP.created == datetime.datetime(
-            2016, 1, 30, 23, 50, tzinfo=tzoffset(None, 0)
+            2016, 1, 30, 23, 50, tzinfo=timezone.utc
         )
diff --git a/tests/unit/images/test_client.py b/tests/unit/images/test_client.py
@@ -1,8 +1,8 @@
 import datetime
+from datetime import timezone
 from unittest import mock
 
 import pytest
-from dateutil.tz import tzoffset
 
 from hcloud.actions.client import BoundAction
 from hcloud.images.client import BoundImage, ImagesClient
@@ -26,14 +26,14 @@ def test_bound_image_init(self, image_response):
         assert bound_image.image_size == 2.3
         assert bound_image.disk_size == 10
         assert bound_image.created == datetime.datetime(
-            2016, 1, 30, 23, 50, tzinfo=tzoffset(None, 0)
+            2016, 1, 30, 23, 50, tzinfo=timezone.utc
         )
         assert bound_image.os_flavor == "ubuntu"
         assert bound_image.os_version == "16.04"
         assert bound_image.architecture == "x86"
         assert bound_image.rapid_deploy is False
         assert bound_image.deprecated == datetime.datetime(
-            2018, 2, 28, 0, 0, tzinfo=tzoffset(None, 0)
+            2018, 2, 28, 0, 0, tzinfo=timezone.utc
         )
 
         assert isinstance(bound_image.created_from, BoundServer)
diff --git a/tests/unit/images/test_domain.py b/tests/unit/images/test_domain.py
@@ -1,6 +1,5 @@
 import datetime
-
-from dateutil.tz import tzoffset
+from datetime import timezone
 
 from hcloud.images.domain import Image
 
@@ -9,5 +8,5 @@ class TestImage:
     def test_created_is_datetime(self):
         image = Image(id=1, created="2016-01-30T23:50+00:00")
         assert image.created == datetime.datetime(
-            2016, 1, 30, 23, 50, tzinfo=tzoffset(None, 0)
+            2016, 1, 30, 23, 50, tzinfo=timezone.utc
         )
diff --git a/tests/unit/isos/test_client.py b/tests/unit/isos/test_client.py
@@ -1,8 +1,8 @@
 import datetime
+from datetime import timezone
 from unittest import mock
 
 import pytest
-from dateutil.tz import tzoffset
 
 from hcloud.isos.client import BoundIso, IsosClient
 
@@ -21,7 +21,7 @@ def test_bound_iso_init(self, iso_response):
         assert bound_iso.type == "public"
         assert bound_iso.architecture == "x86"
         assert bound_iso.deprecated == datetime.datetime(
-            2018, 2, 28, 0, 0, tzinfo=tzoffset(None, 0)
+            2018, 2, 28, 0, 0, tzinfo=timezone.utc
         )
 
 
diff --git a/tests/unit/isos/test_domain.py b/tests/unit/isos/test_domain.py
diff --git a/tests/unit/load_balancers/test_domain.py b/tests/unit/load_balancers/test_domain.py
diff --git a/tests/unit/networks/test_client.py b/tests/unit/networks/test_client.py
diff --git a/tests/unit/networks/test_domain.py b/tests/unit/networks/test_domain.py
diff --git a/tests/unit/placement_groups/test_domain.py b/tests/unit/placement_groups/test_domain.py
diff --git a/tests/unit/primary_ips/test_domain.py b/tests/unit/primary_ips/test_domain.py
diff --git a/tests/unit/servers/test_domain.py b/tests/unit/servers/test_domain.py
diff --git a/tests/unit/ssh_keys/test_domain.py b/tests/unit/ssh_keys/test_domain.py
diff --git a/tests/unit/volumes/test_client.py b/tests/unit/volumes/test_client.py
diff --git a/tests/unit/volumes/test_domain.py b/tests/unit/volumes/test_domain.py
