Merge pull request m1entus#79 from PrideChung/master

m1entus · m1entus · commit bad1a87a72ca · 2016-03-13T18:47:06.000+01:00
Check alreadyUpdating before setting contentInset to prevent potential infinite loop
diff --git a/INSPullToRefresh/INSPullToRefreshBackgroundView.m b/INSPullToRefresh/INSPullToRefreshBackgroundView.m
@@ -380,9 +380,7 @@ - (void)setScrollViewContentInset:(UIEdgeInsets)contentInset {
     BOOL alreadyUpdating = _updatingScrollViewContentInset; // Check to prevent errors from recursive calls.
     if (!alreadyUpdating) {
         self.updatingScrollViewContentInset = YES;
-    }
-    self.scrollView.contentInset = contentInset;
-    if (!alreadyUpdating) {
+        self.scrollView.contentInset = contentInset;
         self.updatingScrollViewContentInset = NO;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -380,9 +380,7 @@ - (void)setScrollViewContentInset:(UIEdgeInsets)contentInset {`
`380`	`380`	`BOOL alreadyUpdating = _updatingScrollViewContentInset; // Check to prevent errors from recursive calls.`
`381`	`381`	`if (!alreadyUpdating) {`
`382`	`382`	`self.updatingScrollViewContentInset = YES;`
`383`		`- }`
`384`		`- self.scrollView.contentInset = contentInset;`
`385`		`- if (!alreadyUpdating) {`
	`383`	`+ self.scrollView.contentInset = contentInset;`
`386`	`384`	`self.updatingScrollViewContentInset = NO;`
`387`	`385`	`}`
`388`	`386`	`}`