better splitString

[dkebler]

Ok so worked up some changes to splitString function, plus wrote some corresponding tests, and updated the readme

• allow multiple separator delimiters
• split string elements in an array path if requested

I see that I could have just wrote my own string split but now these features are incorporated. Nothing has changed per former usage (single delimiter works, don't split string elements by default).

in my use case I needed to split any elements that may contain delimiters when passing a path as an array and use more than one delimeter so I wrote this "pre format path" function. Now it is not necessary. :)

 formatPath(path) {
    if (path==null) return path
    if (Array.isArray(path)) {
      path = path.filter(Boolean).join('.')
    } else path = path.replace(/\/:/g, '.')
    return path
  }

Along the way I came up with another way using regex look behind to find \\ and not split those, then remove them. Avoids that loop with slices and such :).

There is only one thing that bothers me and that is the caching. Some time the fn() is not being called cause it thinks the value is in the cache

const val = setValue.cache.get(key) || fn();

in my test for splitting elements

    it('should split any string elements of an array path if requested', () => {
      const o = {};
      const key1 = Symbol('key-1');
      set(o, ['a.b', key1, 'c'], 'd');
      assert.equal(o['a.b'][key1].c, 'd');

      const o2 = {};
      set(o2, ['z.b', key1, 'c'], 'd', { elSplit: true });
      assert.equal(o2.z.b[key1].c, 'd');
    });

note the 'z.b' if you change that to 'a.b' the test will throw error because fn is not called.
not exactly grokking how this cache is working (it is even a different object so different cache?)
It seems like a testing issue as the example works fine

gone for a few days but able to make updates later in the week per your review.

[jonschlinkert]

Hi @dkebler sorry for taking so long to reply. Currently, set-value supports a custom function for splitting the string. Can you accomplish what you want by using that with your function?

FWIW, on a related note, I also needed similar functionality recently, but for getting vs setting. I created expand-value for that use case.

[dkebler]

All is good my end.

I had been using my forked version but given latest node has native esm and inspired by you I've written a one package esm replacement for get,set,del-value that also exports related path/keys utility functions. I call it obj-nested-prop.

expand-value may be useful to me, thx. Closing this