Skip to content

fix the second parameter bug in issue #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix the second parameter bug in issue #7

wants to merge 2 commits into from

Conversation

caoxiaoshuai1
Copy link

No description provided.

@phated
Copy link
Collaborator

phated commented May 13, 2018

@jonschlinkert @doowb what do you guys think of this?

@doowb
Copy link
Collaborator

doowb commented May 14, 2018

I think it looks good. Using an if statement might be a little faster than Math.min though.

if (n > len) {
  n = len;
}

lukeed added a commit to lukeed/array-last that referenced this pull request Jul 16, 2018
@lukeed
return full Array when n exceeds length
fcec76c 
~> Closes jonschlinkert#7
@lukeed lukeed mentioned this pull request Jul 16, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caoxiaoshuai1 @phated @doowb