Skip to content

Commit 1bea060

Browse files
committed
Use entrypoint instead of cmd
1 parent d54da60 commit 1bea060

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,4 +52,4 @@ RUN mkdir -p /home/project && mv demo/* /home/project/ && rm -rf demo
5252

5353
# And away we go
5454
EXPOSE 3000
55-
CMD node /home/theia/browser-app/src-gen/backend/main.js /home/project --hostname 0.0.0.0
55+
ENTRYPOINT ["node", "/home/theia/browser-app/src-gen/backend/main.js", "/home/project", "--hostname", "0.0.0.0"]

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,12 +101,12 @@ It's not worth the effort getting rstudio server to work on mac. So I found it b
101101

102102
Prerequisite: Install https://github.com/sharkdp/fd
103103

104-
Build the docker image from above
104+
Build the docker image from above (Alternatively, if you haven't changed the packages, you can just use the already published docker image)
105105

106106
In this directory start up the container
107107

108-
docker run -it --rm -p 3000:3000 $(fd -d 1 | sed "s#^\(.*\)#-v $PWD/\1:/home/theia/\1#" | tr '\n' ' ') jonrad/theia-datascience bash
109-
yarn start:browser --hostname 0.0.0.0
108+
docker run -it --rm -p 3000:3000 $(fd -d 1 | sed "s#^\(.*\)#-v $PWD/\1:/home/theia/\1#" | tr '\n' ' ') --entrypoint bash jonrad/theia-datascience
109+
yarn start:browser
110110

111111

112112
Now you can still develop locally and even run `yarn watch` but you'll have to start the main app in the docker container

0 commit comments

Comments
 (0)