Skip to content

Commit 49bce15

Browse files
vzapolskiyFelipe Balbi
authored andcommitted
usb: gadget: xilinx: fix devm_ioremap_resource() check
devm_ioremap_resource() returns IOMEM_ERR_PTR() and it never returns NULL, fix the check to prevent access to invalid virtual address. Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> Reviewed-by: Sören Brinkmann <soren.brinkmann@xilinx.com> Signed-off-by: Felipe Balbi <balbi@ti.com>
1 parent 2283219 commit 49bce15

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/usb/gadget/udc/udc-xilinx.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2071,8 +2071,8 @@ static int xudc_probe(struct platform_device *pdev)
20712071
/* Map the registers */
20722072
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
20732073
udc->addr = devm_ioremap_resource(&pdev->dev, res);
2074-
if (!udc->addr)
2075-
return -ENOMEM;
2074+
if (IS_ERR(udc->addr))
2075+
return PTR_ERR(udc->addr);
20762076

20772077
irq = platform_get_irq(pdev, 0);
20782078
if (irq < 0) {

0 commit comments

Comments
 (0)