-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JavaScript stack traces can still be inaccurate due to createLogger() being async #728
Comments
I can play around with the demo aura component - I think there's probably a way to keep the existing API while improving the experience for aura consumers |
@jamessimone yeah if you have some time to look into this, that'd be great! But I don't think it's just aura components - I'm wrapping up some testing for #727 now, and I'm seeing this issue also happening when using importing MS EdgeThis screenshot is from MS Edge (but I think happens in Chrome too). The Original stack value:
FirefoxIn Firefox, its stack traces seem to work fine (they're also HUGE compared to MS Edge) - the original value from Original
|
This has been fixed in release v4.14.13 via a new |
For some browsers + contexts, JS stack traces are missing info need to determine a JS log entry's origin details. This includes using
async connectedCallback()
createLogger()
no longer async - but some of the related changes could have an impact on existing orgs, with code that does expect it to beasync
.I'd like to explore 2 options:
createLogger()
no longerasync
without causing issues in existing codecreateLogger()
async, but introduce another function that isn't async -createLogger()
would then be considered deprecated, but still supported for nowThe text was updated successfully, but these errors were encountered: