-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logger does not list component type when used in aura component #691
Comments
Worth noting, this issue was also raised today by another person on Reddit. They found that when importing the component directly, in an LWC, it worked correctly, but seemed to work as I've described when grabbing the injected logger component via a template query. https://www.reddit.com/r/SalesforceDeveloper/comments/1czqs5t/nebula_logger_with_lwcs/ |
@ZackFra I've been looking into this issue some more, and I think there's some other aspect related to this problem - I'm also testing with But you're experiencing this issue + so is the person on that Reddit post (thanks for providing that!) + this discussion seems to be the same thing, there's definitely something going on, but I can't make sense of why it only happens for some people/orgs. Let me know if you have any thoughts on what could be causing the difference in behavior. I'll keep trying to reproduce this issue too, maybe it's related to some org setting? |
Interesting. It seems to have something to do with the context in which it's called. So the two scenarios I've found that trigger this issue if when it's an aura component on an Experience Cloud site, and when its an aura component embedded in a lightning record page. I just sprung this up in a new trailhead to confirm the lightning record page scenario with the recipe from the repo. If you change the recipe to implement "flexipage:availableForAllPageTypes", put it on the lightning record page for Accounts, then click the button to trigger the log, you see this: |
@ZackFra, I finally had some time to look into this further, and you were 100% correct that it's based on the context in which it's called. In particular, 2 aspects of the context seem to matter:
Setting Up Some TestsTo try to get a better understanding of what scenarios are having issues, I spent some time setting up metadata in a scratch org & tested the JS stack traces that were generated in several contexts + browsers. Below are the scenarios & results of what I tested, using the latest version of Nebula Logger (without your fixes in PR #692)
Test Results SummaryThere are still several other targets available that I haven't tested yet, but my guess is that there would be some similar issues with certain targets. But based on the testing results I have so far, it seems like there are 2 main issues:
Next StepsI think that several of the existing issues can be fixed easily/have been fixed by your changes in #692, but there are a few contexts that I think still have some problems. There are a couple of things that I'm planning to do next:
Resolving all of the scenarios might end up taking a few releases to fully address everything, but my hope is to release a new version ASAP that addresses at least several of the "quick-fix" issues. |
@ZackFra another update on this - I've spent the last few weeks doing additional testing, and exploring options on how to resolve some of the (several) bugs.
I'm hoping to merge #727 this week. |
JavaScript stack trace parsing has now been fixed (I hope 😅 ) in release Thanks again for all of your help with this! |
@jongpie No problem man! Glad I could help! Love the Nebula Logger by the way, keep up the good work! :) |
Package Edition of Nebula Logger
Unlocked Package
Package Version of Nebula Logger
v4.13.11
New Bug Summary
Attempted to use the lwc logger in an aura component. Retrieved the logger with the following code and saw that although the component section appeared on the log entry page, it was blank.
component file:
controller file
Observed that the following log entry was created after clicking "Log".
The component section was visible, but not populated.
Suspected this had something to do with the stack being generated in the LWC, but I would think that would've marked this log entry as an LWC if that was the case?
Played around with it for a few hours, modified the code a bit, injected the "stack" attribute with a stack generated from the aura component and passed down, still saw the same results.
The text was updated successfully, but these errors were encountered: