Skip to content

Commit daa5d91

Browse files
authored
Stop using downloadURL property from Task Snapshot (firebase#469)
2 parents 1b310e0 + bab1b93 commit daa5d91

File tree

2 files changed

+21
-8
lines changed

2 files changed

+21
-8
lines changed

storage/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ dependencies {
2929
implementation 'com.android.support:appcompat-v7:27.1.0'
3030
implementation 'com.android.support:support-v4:27.1.0'
3131

32-
implementation 'com.google.firebase:firebase-auth:12.0.1'
33-
implementation 'com.google.firebase:firebase-storage:12.0.1'
32+
implementation 'com.google.firebase:firebase-auth:15.0.0'
33+
implementation 'com.google.firebase:firebase-storage:15.0.0'
3434

3535
androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.1'
3636
androidTestImplementation 'com.android.support.test.espresso:espresso-intents:3.0.1'

storage/app/src/main/java/com/google/firebase/quickstart/firebasestorage/MyUploadService.java

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,10 @@
99
import android.support.v4.content.LocalBroadcastManager;
1010
import android.util.Log;
1111

12+
import com.google.android.gms.tasks.Continuation;
1213
import com.google.android.gms.tasks.OnFailureListener;
1314
import com.google.android.gms.tasks.OnSuccessListener;
15+
import com.google.android.gms.tasks.Task;
1416
import com.google.firebase.storage.FirebaseStorage;
1517
import com.google.firebase.storage.OnProgressListener;
1618
import com.google.firebase.storage.StorageReference;
@@ -88,14 +90,25 @@ public void onProgress(UploadTask.TaskSnapshot taskSnapshot) {
8890
taskSnapshot.getTotalByteCount());
8991
}
9092
})
91-
.addOnSuccessListener(new OnSuccessListener<UploadTask.TaskSnapshot>() {
93+
.continueWithTask(new Continuation<UploadTask.TaskSnapshot, Task<Uri>>() {
9294
@Override
93-
public void onSuccess(UploadTask.TaskSnapshot taskSnapshot) {
94-
// Upload succeeded
95-
Log.d(TAG, "uploadFromUri:onSuccess");
95+
public Task<Uri> then(@NonNull Task<UploadTask.TaskSnapshot> task) throws Exception {
96+
// Forward any exceptions
97+
if (!task.isSuccessful()) {
98+
throw task.getException();
99+
}
100+
101+
Log.d(TAG, "uploadFromUri: upload success");
96102

97-
// Get the public download URL
98-
Uri downloadUri = taskSnapshot.getMetadata().getDownloadUrl();
103+
// Request the public download URL
104+
return photoRef.getDownloadUrl();
105+
}
106+
})
107+
.addOnSuccessListener(new OnSuccessListener<Uri>() {
108+
@Override
109+
public void onSuccess(@NonNull Uri downloadUri) {
110+
// Upload succeeded
111+
Log.d(TAG, "uploadFromUri: getDownloadUri success");
99112

100113
// [START_EXCLUDE]
101114
broadcastUploadFinished(downloadUri, fileUri);

0 commit comments

Comments
 (0)