Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotionClient class was renamed to Client #17

Open
ghzeni opened this issue Mar 14, 2023 · 2 comments
Open

NotionClient class was renamed to Client #17

ghzeni opened this issue Mar 14, 2023 · 2 comments

Comments

@ghzeni
Copy link

ghzeni commented Mar 14, 2023

Hello! I don't know if this was planned due to it being a beta version and whatnot, but using notion_api: ^2.0.0-beta2 in the dependencies and using the example, there is an error due to a class name change from NotionClient to Client.

I'm not familiar with issues or commenting on other people's packages, just wanted to let you know that the example is outdated with the most recent version 😁

@jonathangomz
Copy link
Owner

Yeess, I'm so sorry but I haven't touch this project in a while and I could not finish to let the beta version working, so probably is as you say and the fact that probably notion already change stuff with his API, but I'm not sure.

If it helps feel free to use the code as a base because I don't know when I'm going to be able to work again in this package, but thank you for letting me know, I will let the Issue open hoping for the best 😢

@ghzeni
Copy link
Author

ghzeni commented Mar 15, 2023

Yeess, I'm so sorry but I haven't touch this project in a while and I could not finish to let the beta version working, so probably is as you say and the fact that probably notion already change stuff with his API, but I'm not sure.

If it helps feel free to use the code as a base because I don't know when I'm going to be able to work again in this package, but thank you for letting me know, I will let the Issue open hoping for the best 😢

No problem! I'd love to contribute if I had the necessary knowledge, but as of now I'm still a complete beginner to all of this 😁

Either way, congratulations on the package! It's very easy to use and gets the job done. I can't imagine how complicated it must be to create a package from scratch. Amazing work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants