[WIP] PoC for a Node.JS backend using nodegit

node/app/Context.ts

@@ -17,7 +17,7 @@ interface BreadcrumbPath {
 export class NotFoundError extends Error {}
 
 
-export const repoNameFromRequest = (req: express.Request) => {
+const repoNameFromRequest = (req: express.Request) => {
 	return req.params.namespace
 		? `${req.params.namespace}/${req.params.repo}`
 		: req.params.repo
@@ -57,9 +57,13 @@ export class Context {
 	}
 
 	async initialize(): Promise<void> {
-		try {
+		if (await Utils.fileExists(`${Repo.ROOT_REPOS}/${this.repoName}.git`)) {
+			/// bare repo
 			this.repo = await Git.Repository.openBare(`${Repo.ROOT_REPOS}/${this.repoName}.git`);
-		} catch {
+		} else if (await Utils.fileExists(`${Repo.ROOT_REPOS}/${this.repoName}/.git`)) {
+			/// non-bare repo
+			this.repo = await Git.Repository.open(`${Repo.ROOT_REPOS}/${this.repoName}/.git`);
+		} else {
 			throw new NotFoundError(`No such repository ${this.repoName}`);
 		}
 
@@ -157,6 +161,10 @@ export class BlobContext extends Context {
 		return this.blob.rawsize() > 10**9;
 	}
 
+	/**
+	 * Highlight content with hljs,
+	 * and store in this.data.
+	 */
 	renderText() {
 		const ext = Utils.trimPrefix(extname(this.path!), ".");
 		const str = this.blob.toString();

node/app/Repo.ts

@@ -11,16 +11,23 @@ import { Utils } from '../lib/Utils';
 export namespace Repo {
 	export const ROOT_REPOS = __rootDir+`/repositories`;
 
-	export function name(r: Git.Repository) {
-		return Utils.trimSuffix(path.relative(ROOT_REPOS, r.path()), '.git');
+	export function name(repo: Git.Repository) {
+		const rel = path.relative(ROOT_REPOS, repo.path());
+		if (rel.endsWith(`/.git`)) {
+			/// non-bare repo
+			return Utils.trimSuffix(rel, `/.git`);
+		} else {
+			/// bare repo
+			return Utils.trimSuffix(rel, '.git');
+		}
 	}
 
-	export async function refs(r: Git.Repository): Promise<{
+	export async function refs(repo: Git.Repository): Promise<{
 		tags: string[];
 		branches: string[];
 	}> {
-		const tags = await Git.Tag.list(r);
-		const branches = (await r.getReferences())
+		const tags = await Git.Tag.list(repo);
+		const branches = (await repo.getReferences())
 			.filter(x => x.isBranch())
 			.map(x => x.shorthand())
 		;
@@ -33,11 +40,10 @@ export namespace Repo {
 	): Promise<number> {
 		const revWalk = repo.createRevWalk();
 		revWalk.push(before.id());
-		let i = 1;
+		let i = 0;
 		/// ^^ Include `before` in the count.
 		while (true) {
 			try {
-				await revWalk.next();
 				i++;
 			} catch(err) {
 				if (err.errno === Git.Error.CODE.ITEROVER) {

node/lib/Utils.ts

@@ -92,6 +92,18 @@ export namespace Utils {
 		return arr.filter((x): x is T => x !== undefined);
 	}
 
+	/**
+	 * Does local file exist.
+	 */
+	export async function fileExists(path: string): Promise<boolean> {
+		try {
+			await fs.promises.access(path);
+			return true;
+		} catch {
+			return false;
+		}
+	}
+
 	/**
 	 * Recursive readdir matching fs.Dirent[]
 	 * 

node/server.ts

@@ -39,20 +39,21 @@ app.get(
  * not containing a `/`.
  */
 
- 
+
 /**
  * Routes(html)
  */
 
 app.get('/', async function(req, res) {
 	const repoFolders = await Utils.readdirREnt(
 		Repo.ROOT_REPOS,
-		(x) => x.name.endsWith(`.git`),
+		(x) => x.name === `.git` || x.name.endsWith(`.git`),
 		2
 	);
 	/// Assume top-level or nesting=1 folders in this dir
 	/// are our repos.
 	/// Also assume they are bare repos.
+	/// Update: Also support non-bare repos, but only at top-level.
 	const repos = await Promise.all(repoFolders.map(x => {
 		return Git.Repository.openBare(x);
 	}));
@@ -115,6 +116,7 @@ app.get('/:namespace/:repo/raw/:rev/*', rawBlob);
 app.get(           '/:repo/blame/:rev/*', blameBlob);
 app.get('/:namespace/:repo/blame/:rev/*', blameBlob);
 
+
 app.get(           '/:repo/commit/:rev', viewCommit);
 app.get('/:namespace/:repo/commit/:rev', viewCommit);
 

node/views/repo_list.hbs

@@ -8,15 +8,15 @@
     {{/eq}}
   </span>
 </h2>
-<ul class=repolist>
+<ul class="repolist">
   {{#each items as |item|}}
     <li>
       <a
-        href="/{{repo_name item.repo}}"
+        href="/{{ repo_name item.repo }}"
       >
-        <div class=name>{{repo_name item.repo}}</div>
-        <div class=last-updated>
-          last updated {{ call item.commit "date" }}
+        <div class="name">{{ repo_name item.repo }}</div>
+        <div class="last-updated">
+          last updated {{ dateUTC (call item.commit "date") }}
         </div>
       </a>
     </li>