Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated schemas are not valid when using Rust style names in ref #798

Closed
waltronix opened this issue Nov 4, 2024 · 2 comments
Closed

Generated schemas are not valid when using Rust style names in ref #798

waltronix opened this issue Nov 4, 2024 · 2 comments

Comments

@waltronix
Copy link
Contributor

waltronix commented Nov 4, 2024 •
edited
Loading

Not all generated schemas are valid. Especially when using the Rust style names with <, >, or , for schema name generation it breaks schema validation.

I suggest to add a validation check to declare_snapshot_test and then change the generated names #799
@waltronix waltronix mentioned this issue Nov 4, 2024
Merged
@waltronix
Copy link
Contributor Author

The problem does not come from the , itself, but from the space after it.

@jonasbb
Copy link
Owner

jonasbb commented Dec 25, 2024

Closed with #799

@jonasbb jonasbb closed this as completed Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonasbb @waltronix