Remove OSGi

[OSGi] Remove OSGi

Author: aslakhellesoy

CHANGELOG.md

@@ -23,6 +23,10 @@ Please see [CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CO
 ### Deprecated
 
 ### Removed
+  * [OSGi] Jars are no longer packaged as OSGi bundles. The `osgi` module and `pax-exam` examples have been removed as well.
+    ([#1404](https://github.com/cucumber/cucumber-jvm/pull/1404)
+     [cucumber/cucumber#412](https://github.com/cucumber/cucumber/issues/412)
+     Aslak Hellesøy)
   * [Core] Remove deprecated TestStep methods ([#1391](https://github.com/cucumber/cucumber-jvm/pull/1391) M.P. Korstanje)
 
 ### Fixed

core/pom.xml

@@ -79,7 +79,6 @@
                 <artifactId>maven-jar-plugin</artifactId>
                 <configuration>
                     <archive>
-                        <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
                         <manifest>
                             <mainClass>cucumber.api.cli.Main</mainClass>
                         </manifest>
@@ -95,17 +94,6 @@
                 </configuration>
             </plugin>
 
-            <plugin>
-                <groupId>org.apache.felix</groupId>
-                <artifactId>maven-bundle-plugin</artifactId>
-                <configuration>
-                    <instructions>
-                        <Bundle-Description />
-                        <DynamicImport-Package>*</DynamicImport-Package>
-                    </instructions>
-                </configuration>
-            </plugin>
-
         </plugins>
     </build>
 </project>

core/src/test/java/cucumber/runtime/UtilsTest.java

@@ -2,15 +2,12 @@
 
 import org.junit.Test;
 
-import java.lang.reflect.Method;
 import java.net.MalformedURLException;
 import java.net.URL;
-import java.net.URLClassLoader;
 
 import static cucumber.runtime.Utils.isInstantiable;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertNotEquals;
 import static org.junit.Assert.assertTrue;
 
 public class UtilsTest {
@@ -36,69 +33,4 @@ public void test_url() throws MalformedURLException {
         URL url = new URL(dotCucumber, "stepdefs.json");
         assertEquals(new URL("file:foo/bar/.cucumber/stepdefs.json"), url);
     }
-
-    @Test
-    public void testInvokeDefaultClassLoader() throws Throwable {
-        // Sanity check to verify that MyClass was loaded by the default class loader/
-        assertEquals(ClassLoader.getSystemClassLoader(), MyClass.class.getClassLoader());
-        Object target = new MyClass();
-
-        Method publicInterfaceMethod = MyClass.class.getMethod("publicInterfaceMethod");
-        assertEquals(Boolean.TRUE, Utils.invoke(target, publicInterfaceMethod, 1000));
-
-        Method protectedAbstractMethod = MyClass.class.getDeclaredMethod("protectedAbstractMethod");
-        assertEquals(Boolean.TRUE, Utils.invoke(target, protectedAbstractMethod, 1000));
-
-        Method privateMethod = MyAbstractClass.class.getDeclaredMethod("privateMethod");
-        assertEquals(Boolean.TRUE, Utils.invoke(target, privateMethod, 1000));
-    }
-
-    @Test
-    public void testInvokeOtherClassLoader() throws Throwable {
-        // Create a new class loader using the same URLs as the system class loader
-        URL[] urls = ((URLClassLoader) ClassLoader.getSystemClassLoader()).getURLs();
-        ClassLoader myClassLoader = new URLClassLoader(urls, null);
-
-        // Load the test class MyClass using our newly create class loader and create an instance.
-        Class<?> myClass = myClassLoader.loadClass(MyClass.class.getName());
-        Object target = myClass.getConstructor().newInstance();
-
-        // Sanity check to verify that MyClass was loaded by the default class loader.
-        assertEquals(ClassLoader.getSystemClassLoader(), MyClass.class.getClassLoader());
-        // Verify that the class loader of our loaded class is different.
-        assertNotEquals(MyClass.class.getClassLoader(), myClass.getClassLoader());
-
-        Method publicInterfaceMethod = MyClass.class.getMethod("publicInterfaceMethod");
-        assertEquals(Boolean.TRUE, Utils.invoke(target, publicInterfaceMethod, 1000));
-
-        Method protectedAbstractMethod = MyClass.class.getDeclaredMethod("protectedAbstractMethod");
-        assertEquals(Boolean.TRUE, Utils.invoke(target, protectedAbstractMethod, 1000));
-
-        Method privateMethod = MyAbstractClass.class.getDeclaredMethod("privateMethod");
-        assertEquals(Boolean.TRUE, Utils.invoke(target, privateMethod, 1000));
-    }
-
-    public static interface MyInterface {
-        Boolean publicInterfaceMethod();
-    }
-
-    public static abstract class MyAbstractClass implements MyInterface {
-        protected abstract Boolean protectedAbstractMethod();
-
-        private Boolean privateMethod() {
-            return Boolean.TRUE;
-        }
-    }
-
-    public static class MyClass extends MyAbstractClass {
-        @Override
-        public Boolean publicInterfaceMethod() {
-            return Boolean.TRUE;
-        }
-
-        @Override
-        protected Boolean protectedAbstractMethod() {
-            return Boolean.TRUE;
-        }
-    }
 }