Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate validation logic #357

Open
3 tasks
mnzaki opened this issue Sep 6, 2019 · 0 comments
Open
3 tasks

Consolidate validation logic #357

mnzaki opened this issue Sep 6, 2019 · 0 comments
Labels
tech debt Issues we need to address to make improve code quality

Comments

@mnzaki
Copy link
Contributor

mnzaki commented Sep 6, 2019 •
edited
Loading

Description

Currently in two places: utils/validation and identityWallet.validateJWT. Perhaps it needs a "Validator" class/interface of some sort? or perhaps just keep them as utils?

Note that the validation logic paths are the only ones that needs to be able to resolve non-jolo DIDs and so require a resolver function. Containing that requirement into a new class/interface can be helpful.

Part of #355

TODO

  • decide about class vs utils and refactor accordingly
  • move out validateJWT logic and deprecate its usage
  • what about SoftwareKeyProvider.verifyDigestable ?
@mnzaki mnzaki mentioned this issue Sep 6, 2019
Open
6 tasks
@mnzaki mnzaki added the tech debt Issues we need to address to make improve code quality label Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt Issues we need to address to make improve code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mnzaki