Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable PHP FPM status page on /php-fpm-status #188

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Enable PHP FPM status page on /php-fpm-status #188

merged 1 commit into from
Jun 27, 2022

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Jun 27, 2022

No description provided.

@lyrixx lyrixx changed the title Enabled PHP FPM status page on /php-fpm-status Enable PHP FPM status page on /php-fpm-status Jun 27, 2022
pyrech
pyrech approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@pyrech pyrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would even more awesome to secure the status page according to an env var / invoke configuration var, it would avoid people using this stack in production to not miss that the endpoint is active by default

pyrech
pyrech approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@pyrech pyrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems good now 👍 Thank you

infrastructure/docker/services/frontend/etc/nginx/nginx.conf Outdated Show resolved Hide resolved
@lyrixx lyrixx force-pushed the fpm branch 3 times, most recently from bbc9d00 to d9b1726 Compare June 27, 2022 10:04
@lyrixx
Copy link
Member Author

lyrixx commented Jun 27, 2022

Thanks for the review. The dashboard is forbidden by default now in order to not expose some internal information in production. I added a cookbook to explain how to enable it to increase discoverability of the feature.

@lyrixx lyrixx merged commit e368895 into main Jun 27, 2022
@lyrixx lyrixx deleted the fpm branch June 27, 2022 12:06
@lyrixx
Copy link
Member Author

lyrixx commented Jun 27, 2022 •
edited
Loading

Thanks for the review 💛

here we go https://github.com/jolicode/docker-starter#how-to-use-php-fpm-status-page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrech pyrech pyrech approved these changes

@damienalexandre damienalexandre damienalexandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lyrixx @damienalexandre @pyrech