Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implicit Optional issues #1748

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Fix implicit Optional issues #1748

merged 2 commits into from
Nov 14, 2022

Conversation

palfrey
Copy link
Contributor

@palfrey palfrey commented Nov 12, 2022

What does this change

Corrects various types that had a None default, but a type without None being a valid value.

What was wrong

Now that python/mypy#13401 is merged, latest mypy doesn't permit this anymore

How this fixes it

Makes them Optional[X] not X types

fcurella
fcurella approved these changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcurella fcurella merged commit 548d85a into joke2k:master Nov 14, 2022
@palfrey palfrey deleted the fix-typing branch December 2, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcurella fcurella fcurella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palfrey @fcurella