Skip to content

Commit 839e607

Browse files
steveloughranliuml07
authored andcommitted
HADOOP-16827. TestHarFileSystem.testInheritedMethodsImplemented broken. (apache#1817)
This is a regression caused by HADOOP-16759. The test TestHarFileSystem uses introspection to verify that HarFileSystem Does not implement methods to which there is a suitable implementation in the base FileSystem class. Because of the way it checks this, refactoring (protected) FileSystem methods in an IDE do not automatically change the probes in TestHarFileSystem. The changes in HADOOP-16759 did exactly that, and somehow managed to get through the build/test process without this being noticed. This patch fixes that failure. Caused by and fixed by Steve Loughran. Change-Id: If60d9c97058242871c02ad1addd424478f84f446 Signed-off-by: Mingliang Liu <liuml07@apache.org>
1 parent d10f77e commit 839e607

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
package org.apache.hadoop.fs;
2020

2121
import org.apache.hadoop.conf.Configuration;
22+
import org.apache.hadoop.fs.impl.OpenFileParameters;
2223
import org.apache.hadoop.fs.permission.AclEntry;
2324
import org.apache.hadoop.fs.permission.AclStatus;
2425
import org.apache.hadoop.fs.permission.FsAction;
@@ -246,15 +247,11 @@ FutureDataInputStreamBuilder openFile(PathHandle pathHandle)
246247

247248
CompletableFuture<FSDataInputStream> openFileWithOptions(
248249
PathHandle pathHandle,
249-
Set<String> mandatoryKeys,
250-
Configuration options,
251-
int bufferSize) throws IOException;
250+
OpenFileParameters parameters) throws IOException;
252251

253252
CompletableFuture<FSDataInputStream> openFileWithOptions(
254253
Path path,
255-
Set<String> mandatoryKeys,
256-
Configuration options,
257-
int bufferSize) throws IOException;
254+
OpenFileParameters parameters) throws IOException;
258255
}
259256

260257
@Test

0 commit comments

Comments
 (0)