Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earn Report: Improvements #386

Open
Seccour opened this issue Jul 8, 2022 · 2 comments
Open

Earn Report: Improvements #386

Seccour opened this issue Jul 8, 2022 · 2 comments
Labels
concept Wild idea, or too many details unknown yet good first issue Good for newcomers

Comments

@Seccour
Copy link

Seccour commented Jul 8, 2022

Features that would be nice to have on the Earn Report:

  • Being able to browse through older entries. Currently only the last 15 are displayed.
  • Link to the transaction on either local mempool instance or the mempool site when clicking on the timestamp or the CJ amount
  • Either in the note column or in a new one, having the new total balance displayed
@theborakompanioni theborakompanioni added good first issue Good for newcomers concept Wild idea, or too many details unknown yet labels Jul 8, 2022
@theborakompanioni
Copy link
Collaborator

theborakompanioni commented Aug 4, 2022

* Being able to browse through older entries. Currently only the last 15 are displayed.

For v0.0.10 we can use the new table library and enable sorting and pagination.

* Link to the transaction on either local mempool instance or the mempool site when clicking on the timestamp or the CJ amount

Not sure about that. How would we know if a local explorer is present? Also, linking to an external explorer is not something I think is such a good idea. Actually, I am not sure the txid is provided from the backend, so this would need changes in JM itself.

* Either in the note column or in a new one, having the new total balance displayed

I think this can be done, but only if we'd get the outputs of the history CLI command into JM's RPC API.. also needs backend changes (otherwise it is not possible - Jam is just a UI, it does not know what balance you had at a given timestamp).
But generally, showing a history would be great. Not sure if the report is the right place for this, but it'd be nice to have for Jam 💪

@Seccour
Copy link
Author

Seccour commented Sep 18, 2022

* Link to the transaction on either local mempool instance or the mempool site when clicking on the timestamp or the CJ amount

Not sure about that. How would we know if a local explorer is present? Also, linking to an external explorer is not something I think is such a good idea. Actually, I am not sure the txid is provided from the backend, so this would need changes in JM itself.

Maybe having it as an option in the settings ? If the txid is provided, adding a new setting in Jam that say "make transaction clickable" with the following options "no". "external explorer", "internal explorer"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concept Wild idea, or too many details unknown yet good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

2 participants