Merge pull request restsharp#532 from adbre/master

BuildUri: Tell which UrlSegment parameter value is null

Author: haacked

RestSharp.Tests/UrlBuilderTests.cs

@@ -125,6 +125,17 @@ public void GET_with_resource_containing_tokens()
 			Assert.Equal(expected, output);
 		}
 
+		[Fact]
+		public void GET_with_resource_containing_null_token()
+		{
+			var request = new RestRequest("/resource/{foo}", Method.GET);
+			request.AddUrlSegment("foo", null);
+			var client = new RestClient("http://example.com/api/1.0");
+
+			var exception = Assert.Throws<ArgumentException>(() => client.BuildUri(request));
+			Assert.Contains("foo", exception.Message);
+		}
+
 		[Fact]
 		public void POST_with_resource_containing_tokens()
 		{

RestSharp/RestClient.cs

@@ -248,6 +248,11 @@ public Uri BuildUri(IRestRequest request)
 			var urlParms = request.Parameters.Where(p => p.Type == ParameterType.UrlSegment);
 			foreach (var p in urlParms)
 			{
+				if (p.Value == null)
+				{
+					throw new ArgumentException(string.Format("Cannot build uri when url segment parameter '{0}' value is null.", p.Name), "request");
+				}
+
 				assembled = assembled.Replace("{" + p.Name + "}", p.Value.ToString().UrlEncode());
 			}