From 49b4aa1863428b1e7d8f0fcf81b91278c3868961 Mon Sep 17 00:00:00 2001 From: Phillip Johnsen Date: Wed, 16 Sep 2020 22:18:19 +0200 Subject: [PATCH] build: increase API requests for stale action The second attempt at getting the auto closing of issues & PRs to work as expected without hitting a maximum operations allowed error we've been seeing. Recently discovered that the mentioned error is actually self imposed by the stale action itself. It keeps track of how many outgoing GitHub API requests it performs, and if that count exceeds the configured `operations-per-run` option, it exits to avoid hitting API rate limits. Default `operations-per-run` value is set to `30`. That's a very low limit and we're not at all concerned hitting that rate limit as of now, so we're bumping `operations-per-run` to `500` with these changes. Refs https://github.com/nodejs/node/issues/35144 PR-URL: https://github.com/nodejs/node/pull/35235 Reviewed-By: Mary Marchini Reviewed-By: Daijiro Wachi Reviewed-By: Luigi Pinca --- .github/workflows/close-stalled.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/close-stalled.yml b/.github/workflows/close-stalled.yml index 335a1eea471b70..1834d3ac2e6815 100644 --- a/.github/workflows/close-stalled.yml +++ b/.github/workflows/close-stalled.yml @@ -17,6 +17,8 @@ jobs: close-pr-message: Closing this because it has stalled. Feel free to reopen if this PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. # used to filter issues to check whether or not should be closed, avoids hitting maximum operations allowed if needing to paginate through all open issues only-labels: stalled + # max requests it will send per run to the GitHub API before it deliberately exits to avoid hitting API rate limits + operations-per-run: 500 # deactivates automatic removal of stalled label if issue gets any activity remove-stale-when-updated: false # deactivates automatic stale labelling as we prefer to do that manually