This repository was archived by the owner on Mar 5, 2020. It is now read-only.
Split complete function #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows user to use minisnip#complete as complete-function in 'omnifunc' or 'completefunc' Close #19
joereynolds
reviewed
Dec 31, 2017
autoload/minisnip.vim
Outdated
| let l:name = l:f[stridx(l:f[1:], '_') + 2:] | ||
| endif | ||
|
|
||
| if l:name !~? '^' . l:base |
Author
|
Should be.
… Wiadomość napisana przez Joe Reynolds ***@***.***> w dniu 31.12.2017, o godz. 20:53:
@joereynolds commented on this pull request.
In autoload/minisnip.vim <#23 (comment)>:
> @@ -152,25 +152,33 @@ function! minisnip#complete() abort
if l:name !~? '^' . l:base
Should this be a:base?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#23 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARzN5n-cFG7fT81rJMJO3trIIbSEXoWks5tF-ZBgaJpZM4RP7CN>.
--
Łukasz Niemier
lukasz@niemier.pl
|
Author
|
Done. |
Owner
|
I'll try and check it tomorrow, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time it has missing
l:linevariable.