Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnnecessaryModifier PMD warning in generated code (private constructor for enums) #1102

Closed
lasselindqvist opened this issue Mar 3, 2020 · 0 comments
Milestone

Comments

@lasselindqvist
Copy link

The tool generates code that causes PMD UnnecessaryModifier warnings for generated enums .
(https://pmd.github.io/latest/pmd_rules_java_codestyle.html#unnecessarymodifier)
It might make sense to change the autogenerated code not to have

    private SomeEnum(String value) {
        this.value = value;
    }

but

SomeEnum(String value) {
    this.value = value;
}

enum constructor definitions.

@joelittlejohn joelittlejohn added this to the 1.1.1 milestone Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants