Skip to content

ENH backport cpython modification in loky #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 30, 2020
Merged

ENH backport cpython modification in loky #246

merged 10 commits into from
Apr 30, 2020

Conversation

@tomMoral
Copy link
Contributor

@tomMoral tomMoral commented Apr 30, 2020 •
edited
Loading

Closes #245

  • Backport the refactor of the ExecutorManagerThread
  • Backport fix for shutdown no wait
  • Backport new tests

ogrisel
ogrisel reviewed Apr 30, 2020
View reviewed changes
Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass:

@ogrisel
Copy link
Contributor

ogrisel commented Apr 30, 2020

If Python 2 support is too complicated to restore, let's drop it.

@ogrisel
Copy link
Contributor

ogrisel commented Apr 30, 2020

Would be a good opportunity to release loky 3.0 :)

@pierreglaser
Copy link
Collaborator

pierreglaser commented Apr 30, 2020

@tomMoral Indeed, I can polish #237 to merge it before this PR if you'd like. And we can release 3.0 as @ogrisel said :)

ogrisel
ogrisel reviewed Apr 30, 2020
View reviewed changes
@tomMoral tomMoral merged commit adcb9e2 into joblib:master Apr 30, 2020
@tomMoral tomMoral deleted the RFC_backport_executor_manager_thread branch April 30, 2020 14:57
@tomMoral
Copy link
Contributor Author

tomMoral commented Apr 30, 2020

The fixes required to support 2.7 were minor so let's release this 2.7 version (the last one supporting python2.7, ironically).

But all in for the loky3.0 that drops python<3.5`!

@ogrisel
Copy link
Contributor

ogrisel commented Apr 30, 2020

+1

@ogrisel ogrisel mentioned this pull request May 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MTN backport some changes from cpython

3 participants

@tomMoral @ogrisel @pierreglaser