Fix getting :sortText error when sorting completion items #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* eglot.el (eglot-completion-at-point): Fix getting :sortText content of the completion item. Copyright-paperwork-exempt: yes
|
Thanks @galeo , the fix looks OK, but have you not got a copyright assignment yet? Is this your first contribution to Eglot (I didn't check myself)? |
|
I have not signed the copyright paper yet. This is my second contribution to eglot and the first one was pull request #307. |
bhankas
pushed a commit
to bhankas/emacs
that referenced
this pull request
Sep 18, 2022
This fixes a problem pointed out by Yuwei Tian <ibluefocus@gmail.com>. * eglot.el (eglot-completion-at-point): Fix getting :sortText content of the completion item.
bhankas
pushed a commit
to bhankas/emacs
that referenced
this pull request
Sep 19, 2022
This fixes a problem pointed out by Yuwei Tian <ibluefocus@gmail.com>. * eglot.el (eglot-completion-at-point): Fix getting :sortText content of the completion item.
bhankas
pushed a commit
to bhankas/emacs
that referenced
this pull request
Sep 19, 2022
This fixes a problem pointed out by Yuwei Tian <ibluefocus@gmail.com>. * eglot.el (eglot-completion-at-point): Fix getting :sortText content of the completion item. #509: joaotavora/eglot#509
jollaitbot
pushed a commit
to sailfishos-mirror/emacs
that referenced
this pull request
Oct 12, 2022
This fixes a problem pointed out by Yuwei Tian <ibluefocus@gmail.com>. * eglot.el (eglot-completion-at-point): Fix getting :sortText content of the completion item. GitHub-reference: closes joaotavora/eglot#509
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the error that the completion items can not be sorted correctly according to
:sortText, because getting:sortTextcontent always fails. I have tested it with Microsoft's python language server and now it works right.