Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show context of references #52

Closed
brotzeit opened this issue Jul 28, 2018 · 2 comments
Closed

Show context of references #52

brotzeit opened this issue Jul 28, 2018 · 2 comments

Comments

@brotzeit
Copy link
Contributor

eglot:
eglot
lsp-mode:
lsp-mode

Eglot also displays the definition as a reference.
@joaotavora
Copy link
Owner

Hmmm, right, more or less. To understand what you mean, exactly, tell me what you did before getting the prompt in both situations. Does it also happen without helm?

Eglot also displays the definition as a reference

Are you describing a second problem here?

@brotzeit
Copy link
Contributor Author

brotzeit commented Jul 28, 2018 •
edited
Loading

helm-xref is a package I wrote for xref results. I just used xref-find-references for both modes.

Does it also happen without helm?

Yes.

Are you describing a second problem here?

eglot displays one more line than lsp-mode, the definition. That's the first line. It seems this was done for a reason since it is displayed seperately from the other references of that file.

cmm pushed a commit to cmm/eglot that referenced this issue Oct 5, 2018
@mkcms @cmm
Close joaotavora#52: Use entire line as xref summary when possible
801abc3 
* eglot.el (eglot--xref-make): Make the item with summary being the
  whole line at given location, when possible
(eglot--locations-to-xrefs,eglot--path-xrefs,eglot--buf-xrefs):
Convert location list to xref list, trying to open each file just once.
(xref-backend-identifier-at-point):
(xref-backend-definitions):
(xref-backend-references): Pass the list of locations to
eglot--locations-to-xrefs.
cmm pushed a commit to cmm/eglot that referenced this issue Oct 7, 2018
@mkcms @cmm
Close joaotavora#52: Use entire line as xref summary when possible
3f08a66 
* eglot.el (eglot--xref-make): Make the item with summary being the
  whole line at given location, when possible
(eglot--locations-to-xrefs,eglot--path-xrefs,eglot--buf-xrefs):
Convert location list to xref list, trying to open each file just once.
(xref-backend-identifier-at-point):
(xref-backend-definitions):
(xref-backend-references): Pass the list of locations to
eglot--locations-to-xrefs.
cmm pushed a commit to cmm/eglot that referenced this issue Oct 16, 2018
@mkcms @cmm
Close joaotavora#52: Use entire line as xref summary when possible
0164c02 
* eglot.el (eglot--xref-make): Make the item with summary being the
  whole line at given location, when possible
(eglot--locations-to-xrefs,eglot--path-xrefs,eglot--buf-xrefs):
Convert location list to xref list, trying to open each file just once.
(xref-backend-identifier-at-point):
(xref-backend-definitions):
(xref-backend-references): Pass the list of locations to
eglot--locations-to-xrefs.
cmm pushed a commit to cmm/eglot that referenced this issue Nov 3, 2018
@mkcms @cmm
Close joaotavora#52: Use entire line as xref summary when possible
57ccd02 
* eglot.el (eglot--xref-make): Make the item with summary being the
  whole line at given location, when possible
(eglot--locations-to-xrefs,eglot--path-xrefs,eglot--buf-xrefs):
Convert location list to xref list, trying to open each file just once.
(xref-backend-identifier-at-point):
(xref-backend-definitions):
(xref-backend-references): Pass the list of locations to
eglot--locations-to-xrefs.
cmm pushed a commit to cmm/eglot that referenced this issue Nov 5, 2018
@mkcms @cmm
Close joaotavora#52: Use entire line as xref summary when possible
4c1f656 
* eglot.el (eglot--xref-make): Make the item with summary being the
  whole line at given location, when possible
(eglot--locations-to-xrefs,eglot--path-xrefs,eglot--buf-xrefs):
Convert location list to xref list, trying to open each file just once.
(xref-backend-identifier-at-point):
(xref-backend-definitions):
(xref-backend-references): Pass the list of locations to
eglot--locations-to-xrefs.
cmm pushed a commit to cmm/eglot that referenced this issue Nov 19, 2018
@mkcms @cmm
Close joaotavora#52: Use entire line as xref summary when possible
0f378b6 
* eglot.el (eglot--xref-make): Make the item with summary being the
  whole line at given location, when possible
(eglot--locations-to-xrefs,eglot--path-xrefs,eglot--buf-xrefs):
Convert location list to xref list, trying to open each file just once.
(xref-backend-identifier-at-point):
(xref-backend-definitions):
(xref-backend-references): Pass the list of locations to
eglot--locations-to-xrefs.
joaotavora added a commit that referenced this issue Nov 27, 2018
@joaotavora
Close #52: Use entire line as xref summary when available
f54f140 
After an original implementation by Michael Livshin.

* eglot.el (eglot--xref-make): Rework.
(xref-backend-definitions, xref-backend-references)
(xref-backend-apropos): Simplify call to `eglot--xref-make'.
joaotavora added a commit that referenced this issue Nov 27, 2018
@joaotavora
Fix #52: Use entire line as xref summary when available
5faf699 
After an original implementation by Michael Livshin.  Also close #127.

* eglot.el (eglot--xref-make): Rework.
(xref-backend-definitions, xref-backend-references)
(xref-backend-apropos): Simplify call to `eglot--xref-make'.
joaotavora added a commit that referenced this issue Nov 27, 2018
@joaotavora
Per #52, #127: Improve performance of xref summary line collection
b9f227f 
* eglot.el (eglot--temp-location-buffers): New variable.
(eglot--handling-xrefs): New macro.
(eglot--xref-make): Use eglot--temp-location-buffers.
(xref-backend-definitions, xref-backend-references)
(xref-backend-apropos): Use eglot--handling-xrefs.
mkcms pushed a commit that referenced this issue Nov 27, 2018
@joaotavora @mkcms
Per #52, #127: Improve performance of xref summary line collection
0e39b69 
* eglot.el (eglot--temp-location-buffers): New variable.
(eglot--handling-xrefs): New macro.
(eglot--xref-make): Use eglot--temp-location-buffers.
(xref-backend-definitions, xref-backend-references)
(xref-backend-apropos): Use eglot--handling-xrefs.
joaotavora added a commit that referenced this issue Nov 27, 2018
@joaotavora
Fix #52: Use entire line as xref summary when available
c564e25 
After an original implementation by Michael Livshin.  Also close #127.

* eglot.el (eglot--xref-make): Rework.
(xref-backend-definitions, xref-backend-references)
(xref-backend-apropos): Simplify call to `eglot--xref-make'.
joaotavora added a commit that referenced this issue Nov 27, 2018
@joaotavora
Per #52, #127: Improve performance of xref summary line collection
0ad7b5b 
* eglot.el (eglot--temp-location-buffers): New variable.
(eglot--handling-xrefs): New macro.
(eglot--xref-make): Use eglot--temp-location-buffers.
(xref-backend-definitions, xref-backend-references)
(xref-backend-apropos): Use eglot--handling-xrefs.
joaotavora added a commit that referenced this issue Nov 27, 2018
@joaotavora
Per #52, #127: Improve performance of xref summary line collection
9fb5f0c 
* eglot.el (eglot--temp-location-buffers): New variable.
(eglot--handling-xrefs): New macro.
(eglot--xref-make): Use eglot--temp-location-buffers.
(xref-backend-definitions, xref-backend-references)
(xref-backend-apropos): Use eglot--handling-xrefs.
bhankas pushed a commit to bhankas/emacs that referenced this issue Sep 18, 2022
@joaotavora
Fix joaotavora/eglot#52: Use entire line as xref summary when available
661887b 
After an original implementation by Michael Livshin.  Also close joaotavora/eglot#127.

* eglot.el (eglot--xref-make): Rework.
(xref-backend-definitions, xref-backend-references)
(xref-backend-apropos): Simplify call to `eglot--xref-make'.
bhankas pushed a commit to bhankas/emacs that referenced this issue Sep 18, 2022
@joaotavora
Per joaotavora/eglot#52, joaotavora/eglot#127: Improve performance of…
0b75272 
… xref summary line collection

* eglot.el (eglot--temp-location-buffers): New variable.
(eglot--handling-xrefs): New macro.
(eglot--xref-make): Use eglot--temp-location-buffers.
(xref-backend-definitions, xref-backend-references)
(xref-backend-apropos): Use eglot--handling-xrefs.
bhankas pushed a commit to bhankas/emacs that referenced this issue Sep 19, 2022
@joaotavora
Fix joaotavora/eglot#52: Use entire line as xref summary when available
d449110 
After an original implementation by Michael Livshin.  Also close joaotavora/eglot#127.

* eglot.el (eglot--xref-make): Rework.
(xref-backend-definitions, xref-backend-references)
(xref-backend-apropos): Simplify call to `eglot--xref-make'.
bhankas pushed a commit to bhankas/emacs that referenced this issue Sep 19, 2022
@joaotavora
Per joaotavora/eglot#52, joaotavora/eglot#127: Improve performance of…
9489e5c 
… xref summary line collection

* eglot.el (eglot--temp-location-buffers): New variable.
(eglot--handling-xrefs): New macro.
(eglot--xref-make): Use eglot--temp-location-buffers.
(xref-backend-definitions, xref-backend-references)
(xref-backend-apropos): Use eglot--handling-xrefs.
bhankas pushed a commit to bhankas/emacs that referenced this issue Sep 19, 2022
@joaotavora
Fix #52: Use entire line as xref summary when available
b1e8b37 
After an original implementation by Michael Livshin.  Also close #127.

* eglot.el (eglot--xref-make): Rework.
(xref-backend-definitions, xref-backend-references)
(xref-backend-apropos): Simplify call to `eglot--xref-make'.

#52: joaotavora/eglot#52
#127: joaotavora/eglot#127
bhankas pushed a commit to bhankas/emacs that referenced this issue Sep 19, 2022
@joaotavora
Per #52, #127: Improve performance of xref summary line collection
74657f5 
* eglot.el (eglot--temp-location-buffers): New variable.
(eglot--handling-xrefs): New macro.
(eglot--xref-make): Use eglot--temp-location-buffers.
(xref-backend-definitions, xref-backend-references)
(xref-backend-apropos): Use eglot--handling-xrefs.

#52: joaotavora/eglot#52
#127: joaotavora/eglot#127
jollaitbot pushed a commit to sailfishos-mirror/emacs that referenced this issue Oct 12, 2022
@joaotavora
Use entire line as xref summary when available
9e700eb 
After an original implementation by Michael Livshin.  Also close joaotavora/eglot#127.

* eglot.el (eglot--xref-make): Rework.
(xref-backend-definitions, xref-backend-references)
(xref-backend-apropos): Simplify call to `eglot--xref-make'.

GitHub-reference: fix joaotavora/eglot#52
jollaitbot pushed a commit to sailfishos-mirror/emacs that referenced this issue Oct 12, 2022
@joaotavora
Improve performance of xref summary line collection
e63203a 
* eglot.el (eglot--temp-location-buffers): New variable.
(eglot--handling-xrefs): New macro.
(eglot--xref-make): Use eglot--temp-location-buffers.
(xref-backend-definitions, xref-backend-references)
(xref-backend-apropos): Use eglot--handling-xrefs.

GitHub-reference: per joaotavora/eglot#52
GitHub-reference: per joaotavora/eglot#127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joaotavora @brotzeit