New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Holidays FR #82

Closed

YDEFAY opened this issue Dec 15, 2017 · 1 comment

YDEFAY commented Dec 15, 2017

Hi, thanks for your DateTimeExttensions !
It's usefull and work realy great.

There are 2 days you can fix for french culture :

August 15 is holiday (Assumption of Mary)
December 26 is a specific holiday for some departments (just a few people doesn't work on this day)

So if you can add August 15 and remove December 26 your french holidays calendar becomes right.

Thank you in advance

joaomatossilva closed this as completed in

de272b4

Owner

joaomatossilva commented Jan 7, 2018

Thanks. I just fixed it, it should be live on next release.

I did not removed the December 26, because since version 5.0 I do now support regions, and so I constrainted it only to Alsace and Lorraine regions only (based on https://en.wikipedia.org/wiki/Public_holidays_in_France)

Can you confirm it's all ok now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment