Remove PHP close tags; documentation; code conventions cleanup

Author: asmecher

CrossrefReferenceLinkingInfoSender.inc.php

@@ -85,4 +85,4 @@ function _getJournals() {
 		return $journals;
 	}
 }
-?>
+

CrossrefReferenceLinkingPlugin.inc.php

@@ -503,4 +503,3 @@ function _getResolvedRefs($doi, $contextId) {
 
 }
 
-?>

CrossrefReferenceLinkingSettingsForm.inc.php

@@ -13,37 +13,18 @@
  * @brief Form for journal managers to setup the reference linking plugin
  */
 
-
 import('lib.pkp.classes.form.Form');
 
 class CrossrefReferenceLinkingSettingsForm extends Form {
-
 	//
 	// Private properties
 	//
 	/** @var integer */
 	var $_contextId;
 
-	/**
-	 * Get the context ID.
-	 * @return integer
-	 */
-	function _getContextId() {
-		return $this->_contextId;
-	}
-
 	/** @var CrossrefReferenceLinkingPlugin */
 	var $_plugin;
 
-	/**
-	 * Get the plugin.
-	 * @return CrossrefReferenceLinkingPlugin
-	 */
-	function _getPlugin() {
-		return $this->_plugin;
-	}
-
-
 	//
 	// Constructor
 	//
@@ -65,6 +46,24 @@ function __construct($plugin, $contextId) {
 		$this->addCheck(new FormValidatorCSRF($this));
 	}
 
+	//
+	// Public methods
+	//
+	/**
+	 * Get the context ID.
+	 * @return integer
+	 */
+	function _getContextId() {
+		return $this->_contextId;
+	}
+
+	/**
+	 * Get the plugin.
+	 * @return CrossrefReferenceLinkingPlugin
+	 */
+	function _getPlugin() {
+		return $this->_plugin;
+	}
 
 	//
 	// Implement template methods from Form
@@ -165,7 +164,5 @@ function getFormFields() {
 	function isOptional($settingName) {
 		return in_array($settingName, array('automaticRegistration', 'testMode'));
 	}
-
 }
 
-?>

README

@@ -20,6 +20,10 @@ OJS 3.1.2
 
 Installation
 ------------
+There are three ways of installing the plugin:
+* Plugin Gallery
+ * Access your journal's plugin gallery as Site Administrator and install the plugin there.
+* Manual installation (not recommended)
  * Copy the release source or unpack the release package into the OJS plugins/generic/crossrefReferenceLinking/ folder.
  * Run `php tools/upgrade.php upgrade` from the OJS folder.
  * Go to Settings -> Website -> Plugins -> Generic Plugin -> Crossref Reference Linking Plugin and enable the plugin.
@@ -35,4 +39,4 @@ Crossref provides funding to support the development of the version 1.0 of this
 Contact/Support
 ---------------
 Documentation, bug listings, and updates can be found on this plugin's homepage
-at <http://github.com/pkp/crossrefReferenceLinkign>.
+at <http://github.com/pkp/crossrefReferenceLinkign>.

index.php

@@ -19,4 +19,3 @@
 
 return new CrossrefReferenceLinkingPlugin();
 
-?>

templates/settingsForm.tpl

@@ -25,4 +25,4 @@
 		<p>{translate key="plugins.generic.crossrefReferenceLinking.settings.form.requirements.ok"}</p>
 	{/if}
 </div>
-</form>
+

tools/checkCrossrefReferencesDOIs.php

@@ -97,4 +97,3 @@ function execute() {
 
 $tool = new CrossrefReferencesDOIsTool(isset($argv) ? $argv : array());
 $tool->execute();
-?>

version.xml

@@ -14,8 +14,8 @@
 	<application>crossrefReferenceLinking</application>
 	<type>plugins.generic</type>
 	<release>1.0.0.0</release>
-	<date>2019-01-22</date>
+	<date>2019-03-27</date>
 	<lazy-load>1</lazy-load>
 	<sitewide>1</sitewide>
 	<class>CrossrefReferenceLinkingPlugin</class>
-</version>
+</version>