Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: avoid declaring Lombok as a transitive dependency #437

Closed
jaguililla opened this issue Jul 19, 2020 · 2 comments · Fixed by #438
Closed

Improvement: avoid declaring Lombok as a transitive dependency #437

jaguililla opened this issue Jul 19, 2020 · 2 comments · Fixed by #438
Labels
done enhancement
Milestone
9.1.2

Comments

@jaguililla
Copy link
Contributor

In the latest release (9.1.0) the Lombok dependency is included, however, it won't be needed at runtime ¿could it be set as "compile only"?

Thanks for your great library!
@jmrozanec
Copy link
Owner

@jaguililla sure, we can do that! If you send a PR with the change, we will be glad to merge it. Thanks! 😄

@jaguililla jaguililla mentioned this issue Jul 19, 2020
Merged
@jaguililla
Copy link
Contributor Author

The proposed change is in the #438 PR.

@jmrozanec jmrozanec added this to the next milestone Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done enhancement
Projects
None yet
Milestone
9.1.2
Development

Successfully merging a pull request may close this issue.

Change Lombok dependency scope
2 participants
@jaguililla @jmrozanec