Calculate the initial condition using only real numbers #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other recursion coefficients were already all using only real number types, but the initial condition was forgotten. This has worked thus far, but a change in the upcoming Julia v1.9 (presumably JuliaLang/julia#47255) broke the exact correspondance between real inputs and real-axis complex inputs for the spherical normalization. Specifically, on Julia 1.8: ```julia julia> r = inv(sqrt(4convert(Float64, π))) 0.28209479177387814 julia> r - real(inv(sqrt(4convert(ComplexF64, π)))) 0.0 ``` while with Julia 1.9: ```julia julia> r = inv(sqrt(4convert(Float64, π))) 0.28209479177387814 julia> r - real(inv(sqrt(4convert(ComplexF64, π)))) -5.551115123125783e-17 ``` The simple change that allows the tests to pass again is to just ask for the initial condition to be calculated in the appropriate real number type.
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=======================================
Coverage 96.57% 96.57%
=======================================
Files 9 9
Lines 350 350
=======================================
Hits 338 338
Misses 12 12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other recursion coefficients were already all using only real number types, but the initial condition was forgotten. This has worked thus far, but a change in the upcoming Julia v1.9 (presumably JuliaLang/julia#47255) broke the exact correspondance between real inputs and real-axis complex inputs for the spherical normalization.
Specifically, on Julia 1.8:
while with Julia 1.9:
The simple change that allows the tests to pass again is to just ask for the initial condition to be calculated in the appropriate real number type.