From 1f2f6be08137d7c9117920afbedb69cf3dff7241 Mon Sep 17 00:00:00 2001 From: Boris Zbarsky Date: Tue, 10 Sep 2024 21:08:20 -0400 Subject: [PATCH] Add a step timeout for Matter.framework unit tests. (#35530) If a test hangs, we end up running until job timeout after 6 hours. But that skips later steps, including log uploads, which makes it harder to figure out why the hang happened. The fix is to use a timeout on the test job that is somewhat shorter than the 6-hour job timeout, so we allow time for the log upload too. --- .github/workflows/darwin.yaml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/darwin.yaml b/.github/workflows/darwin.yaml index 360c5bb6963217..9eeac9118ef9d3 100644 --- a/.github/workflows/darwin.yaml +++ b/.github/workflows/darwin.yaml @@ -105,10 +105,9 @@ jobs: run: | scripts/examples/gn_build_example.sh examples/ota-requestor-app/linux out/debug/ota-requestor-app chip_config_network_layer_ble=false non_spec_compliant_ota_action_delay_floor=0 - name: Run Framework Tests - # For now disable unguarded-availability-new warnings because we - # internally use APIs that we are annotating as only available on - # new enough versions. Maybe we should change out deployment - # target versions instead? + # We want to ensure that our log upload runs on timeout, so use a timeout here shorter + # than the 6-hour overall job timeout. 4.5 hours should be plenty. + timeout-minutes: 270 working-directory: src/darwin/Framework run: | mkdir -p /tmp/darwin/framework-tests