Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish Country Unit Tests #5

Closed
jloh opened this issue Jan 24, 2018 · 1 comment
Closed

Finish Country Unit Tests #5

jloh opened this issue Jan 24, 2018 · 1 comment
Assignees
@jloh
Labels
ip/country tests
Milestone
v1.0.1

Comments

@jloh
Copy link
Owner

jloh commented Jan 24, 2018

Finish off unit tests for Country endpoint

This is going to be a bit difficult since the JSON that gets returned can change the order its in for some reason which is breaking string comparisons.
@jloh jloh added this to the v1.0.0 milestone Jan 24, 2018
@jloh jloh self-assigned this Jan 24, 2018
@jloh jloh mentioned this issue Jan 24, 2018
Merged
@jloh jloh added to do and removed in progress labels Jan 26, 2018
@jloh jloh modified the milestones: v1.0.0, v1.0.1 Mar 10, 2018
@jloh
Copy link
Owner Author

jloh commented Oct 7, 2018

This was done some time ago. With the GeoLite 2 redo tests will need to be ripped apart anyway.

@jloh jloh closed this as completed Oct 7, 2018
@ghost ghost removed the to do label Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jloh jloh

Labels
ip/country tests
Projects
None yet
Milestone
v1.0.1
Development

No branches or pull requests
1 participant
@jloh