From 8710ba23d2b87242f6985b646e547a58db42170e Mon Sep 17 00:00:00 2001 From: Jonathan Lebon Date: Thu, 24 Nov 2022 17:38:17 -0500 Subject: [PATCH] plume/release: drop doS3() code Early in FCOS development, we were still debating whether the S3 objects should be public or not. There was some initial agreement on uploading first as private and then make specific builds public during the release process, but in the end we've just always published in public from the start. It's not likely we'll change this anytime soon unless a good reason comes up. So let's just delete the code here that makes the build objects public since they already are. It'll live on in git at least if we ever want to restore it. Related: https://github.com/coreos/fedora-coreos-tracker/issues/189 --- mantle/cmd/plume/release.go | 9 --------- 1 file changed, 9 deletions(-) diff --git a/mantle/cmd/plume/release.go b/mantle/cmd/plume/release.go index 7be7083770..386412aa43 100644 --- a/mantle/cmd/plume/release.go +++ b/mantle/cmd/plume/release.go @@ -92,7 +92,6 @@ func runFcosRelease(cmd *cobra.Command, args []string) { } api := getAWSApi() - doS3(api) rel := getReleaseMetadata(api) makeReleaseAMIsPublic(rel) modifyReleaseMetadataIndex(api, rel) @@ -126,14 +125,6 @@ func getBucketAndStreamPrefix() (string, string) { return specBucket, filepath.Join("prod", "streams", specStream) } -func doS3(api *aws.API) { - bucket, prefix := getBucketAndStreamPrefix() - err := api.UpdateBucketObjectsACL(bucket, filepath.Join(prefix, "builds", specVersion), specPolicy) - if err != nil { - plog.Fatalf("updating object ACLs: %v", err) - } -} - func getReleaseMetadata(api *aws.API) release.Release { bucket, prefix := getBucketAndStreamPrefix() releasePath := filepath.Join(prefix, "builds", specVersion, "release.json")