Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow HTTPS and arbitrary ports in domain names on the Connect tab #549

Open
tamberg opened this issue Oct 9, 2021 · 0 comments
Open

Allow HTTPS and arbitrary ports in domain names on the Connect tab #549

tamberg opened this issue Oct 9, 2021 · 0 comments

Comments

@tamberg
Copy link

tamberg commented Oct 9, 2021

Hi,

in the Connect tab, under Domain Name, the Web UI seems to enforce HTTP and add a port (as set in the Network tab, usually 8073) to the domain entered. This prevents domain names with HTTPS (e.g. on the standard port 443) from being published on http://kiwisdr.com/public/

To support 3rd party reverse proxies, consider allowing HTTPS and arbitrary ports in the Domain Name URL field, e.g. instead of

my-domain.org => http://my-domain.org:8073

allow entering http:// or https:// and any port, as in

http://my-domain.org:8073 => http://my-domain.org:8073
https://my-domain.org:443 => https://my-domain.org:443
or even https://my-domain.org => https://my-domain.org

(This seems to require a relatively small change in https://github.com/jks-prv/Beagle_SDR_GPS/blob/master/web/kiwi/admin.js but I'm not a JS expert.)

Kind regards, Thomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant